Master #12381
Closed
Master #12381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- IMPORTANT Nix is a non-trivial project, so for your contribution to be successful, it really is important to follow the contributing guidelines: https://github.com/NixOS/nix/blob/master/CONTRIBUTING.md Even if you've contributed to open source before, take a moment to read it, so you understand the process and the expectations. - what information to include in commit messages - proper attribution - volunteering contributions effectively - how to get help and our review process. --> ## Motivation <!-- Briefly explain what the change is about and why it is desirable. --> ## Context <!-- Provide context. Reference open issues if available. --> <!-- Non-trivial change: Briefly outline the implementation strategy. --> <!-- Invasive change: Discuss alternative designs or approaches you considered. --> <!-- Large change: Provide instructions to reviewers how to read the diff. --> --- Add 👍 to [pull requests you find important](https://github.com/NixOS/nix/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc). The Nix maintainer team uses a [GitHub project board](https://github.com/orgs/NixOS/projects/19) to [schedule and track reviews](https://github.com/NixOS/nix/tree/master/maintainers#project-board-protocol).
|
What does this do? Why would some contributors need this? I honestly have no idea, and the way you've presented this PR and its commits isn't helpful. Also what are the criteria by which this file should be maintained? I have no idea how a change to this file would have to be reviewed. Would you be available to co-maintain it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.