Fix #9052 #12558
Draft
Fix #9052 #12558
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to reproduce this race condition going forward (e.g. it depends on the precise order that goals are scheduled, but https://github.com/roberth/nix-9052 current reproduces it, and this fixes that.
Ericson2314
force-pushed
the
fix-9052
branch
from
380b16e to
0607a2e
Compare
cole-h
reviewed
Feb 24, 2025
| @@ -369,6 +369,18 @@ public: | |||
| */ | |||
| Done amDone(ExitCode result, std::optional<Error> ex = {}); | |||
|
|
|||
| /** | |||
| * @return true just for those `ExitCode`s that are avalid argument | |||
There was a problem hiding this comment.
super tiny nit:
Suggested change
| * @return true just for those `ExitCode`s that are avalid argument | |
| * @return true just for those `ExitCode`s that are a valid argument |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-02-24-nix-team-meeting-minutes-215-216/60920/1 |
|
@roberth found a problem with this, so let's not do this. The proper fix is to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9052
Context
It's hard to reproduce this race condition going forward (e.g. it depends on the precise order that goals are scheduled, but https://github.com/roberth/nix-9052 current reproduces it, and this fixes that.
I don't really like how the fix just piles on more complexity, but I have some ideas on how a larger re-work can clean things up.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.