Header cleanup #12940
Merged
Header cleanup #12940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Ericson2314
added
the
backport 2.28-maintenance
Revert most of "Hack together a fix for the public headers" - The `libmain` change is kept, and one more libmain change is made. (Need to update Meson and Nix per the package alike). - The S3 situation is fixed in a different way: the variable is public now, used in the header, and fixed accordingly. - Fix TODO for `HAVE_EMBEDDED_SANDBOX_SHELL` This reverts commit 2b51250.
Now that we have the private vs public distinction, we can do this without leaking information downstream.
Ericson2314
force-pushed
the
header-cleanup
branch
from
60e8629 to
7a7fe35
Compare
roberth
approved these changes
Apr 6, 2025
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 07204ff |
37 tasks
Ericson2314
added a commit
that referenced
this pull request
Apr 7, 2025
…2940 Header cleanup (backport #12940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A better fix than commit 2 from #12931, and some other cleanups while I am at it.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.