Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libutp: init at unstable-2018-05-15 #120512

Closed
wants to merge 8 commits into from
Closed

libutp: init at unstable-2018-05-15 #120512

wants to merge 8 commits into from

Conversation

onny
Copy link
Contributor

@onny onny commented Apr 24, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Apr 24, 2021
View reviewed changes
pkgs/development/libraries/libutp/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libutp/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libutp/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libutp/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libutp/default.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Apr 24, 2021

Okay maybe it's ready now :)

@SuperSandro2000 SuperSandro2000 changed the title libutp: init at master libutp: init at unstable-2018-05-15 Apr 26, 2021
@SuperSandro2000
Copy link
Member

@onny ofborg fails with
CMake Error: The source directory "/build/source" does not appear to contain CMakeLists.txt.

@onny
Copy link
Contributor Author

onny commented May 1, 2021

Okay should be good now 👍

@onny
Copy link
Contributor Author

onny commented Aug 1, 2021

By accident I lost access to the repository of this pull request. I created a new one here.

@onny onny closed this Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onny @SuperSandro2000