Skip to content

python3Packages.django-cryptography: include missing source files#229505

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
centromere:django-cryptography
May 10, 2023
Merged

python3Packages.django-cryptography: include missing source files#229505
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
centromere:django-cryptography

Conversation

@centromere
Copy link
Member

Description of changes

Some source files are missing from the package. This change ensures they are included.

Before:

$ find result/lib/python3.10/site-packages/django_cryptography | grep -v pycache
result/lib/python3.10/site-packages/django_cryptography
result/lib/python3.10/site-packages/django_cryptography/fields.py
result/lib/python3.10/site-packages/django_cryptography/conf.py
result/lib/python3.10/site-packages/django_cryptography/__init__.py

After:

$ find result/lib/python3.10/site-packages/django_cryptography | grep -v pycache
result/lib/python3.10/site-packages/django_cryptography
result/lib/python3.10/site-packages/django_cryptography/core
result/lib/python3.10/site-packages/django_cryptography/core/signing.py
result/lib/python3.10/site-packages/django_cryptography/core/__init__.py
result/lib/python3.10/site-packages/django_cryptography/fields.py
result/lib/python3.10/site-packages/django_cryptography/conf.py
result/lib/python3.10/site-packages/django_cryptography/__init__.py
result/lib/python3.10/site-packages/django_cryptography/utils
result/lib/python3.10/site-packages/django_cryptography/utils/__init__.py
result/lib/python3.10/site-packages/django_cryptography/utils/crypto.py
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 2, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 2, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2183

@SuperSandro2000
Copy link
Member

Can we fetch georgemarshall/django-cryptography#88 instead?

@centromere centromere force-pushed the django-cryptography branch from 698846a to ad694aa Compare May 10, 2023 02:54
@centromere
Copy link
Member Author

@SuperSandro2000 The raw upstream patch did not apply properly, so I generated one and included it in this PR.

@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.django-cryptography

@SuperSandro2000 SuperSandro2000 merged commit 51b8753 into NixOS:master May 10, 2023
@centromere centromere deleted the django-cryptography branch May 10, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants