Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jlink software tools: init at V7.92k #263487

Closed
wants to merge 2 commits into from

Conversation

liarokapisv
Copy link
Contributor

@liarokapisv liarokapisv commented Oct 26, 2023

Description of changes

SEGGER's J-Links are one of the most widely used debug probes available today for embedded usage.
This PR packages their Software and Documentation pack which provides a large set of utilities for use with their debug probes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • [] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@liarokapisv
Copy link
Contributor Author

liarokapisv commented Oct 26, 2023

Tested on Standalone and on NixOS, making sure that the applications run properly with the debug probes.
If one wants to actually test a JLink on NixOS, they will have to add the package to programs.udev.packages for the device to be recognized.

I am aware that the conditional fetchurl instead of requireFile may be a bit controversial.
I believe that it is a bit more ergonomic for users that are aware of the package's license and
want to automate its installation.

If not deemed acceptable, could we perhaps add the sha256 and url attributes to the src's passthru ? I think this requires overriding requireFile, but I may be wrong. Users could then override the src attribute by explicitly using fetchurl and reusing the passthru attributes.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 26, 2023
@liarokapisv
Copy link
Contributor Author

liarokapisv commented Oct 27, 2023

Closing in favor of @StarGate01 's #255185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant