Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsec-bin: 150-90c -> 150-91a #266745

Merged
merged 4 commits into from
Dec 22, 2023
Merged

parsec-bin: 150-90c -> 150-91a #266745

merged 4 commits into from
Dec 22, 2023

Conversation

pabloaul
Copy link
Contributor

@pabloaul pabloaul commented Nov 10, 2023

Description of changes

package 150-90c -> 150-91a
ffmpeg_4 -> ffmpeg_5
add pabloaul as maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 10, 2023
@ofborg ofborg bot requested a review from arcnmx November 10, 2023 23:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 10, 2023
@arcnmx
Copy link
Member

arcnmx commented Nov 12, 2023

The .so that comes with the package then wouldn't work with it (even once updated to 150_90c it won't be new enough), which makes this feel wrong, but it's also likely to be replaced and auto-updated to 150-91 anyway... Including both ffmpeg_4 and ffmpeg_5 is technically also an option but seems overly excessive.
Given that it still works with ffmpeg_4, it's not necessarily a problem to wait to do this until the next package update past 150-91, and one could override until then if desired but... Not sure, that makes me feel a bit torn here.

@pabloaul
Copy link
Contributor Author

pabloaul commented Nov 12, 2023

The .so that comes with the package then wouldn't work with it (even once updated to 150_90c it won't be new enough), which makes this feel wrong, but it's also likely to be replaced and auto-updated to 150-91 anyway... Including both ffmpeg_4 and ffmpeg_5 is technically also an option but seems overly excessive. Given that it still works with ffmpeg_4, it's not necessarily a problem to wait to do this until the next package update past 150-91, and one could override until then if desired but... Not sure, that makes me feel a bit torn here.

Checked their debian binary which was still on 150-90c right now. How long does the binary usually lag behind the actual current version?
I was told that the rollout for 91 should complete somewhen around this or next week. We can hold off on this before getting the version bumped, else people might be stuck on 90c with ffmpeg5.

@Kodikuu
Copy link

Kodikuu commented Dec 8, 2023

Parsec dev here, made aware this exists by @pabloaul mentioning it in the Discord 😅

Our rollout is complete, y'all can use ffmpeg_5

@pabloaul pabloaul changed the title parsec-bin: use ffmpeg_5 parsec-bin: 150-90c -> 150-91a Dec 8, 2023
@ofborg ofborg bot requested a review from arcnmx December 9, 2023 02:07
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 9, 2023
@Atemu
Copy link
Member

Atemu commented Dec 10, 2023

Could you squash the two update commits and follow the contributing message guidelines on your maintainer commits?

@Atemu
Copy link
Member

Atemu commented Dec 22, 2023

(Interpreting the link above as implicit approval by @arcnmx. Please explicitly agree going forward to make things clearer/get things merged quicker.)

@Atemu Atemu merged commit b885dbb into NixOS:master Dec 22, 2023
23 checks passed
@pabloaul pabloaul deleted the parsec-bin branch December 22, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants