Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentik: Fix runtime errors #329151

Merged
merged 1 commit into from
Jul 25, 2024
Merged

authentik: Fix runtime errors #329151

merged 1 commit into from
Jul 25, 2024

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jul 22, 2024

Description of changes

This fixes three runtime errors that prevent authentik from running currently.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Interactive test, completing the initial-setup flow:
nix run git+https://gist.github.com/615c73b304b0a20c91deeba22445e778.git \
  --override-input nixpkgs github:B4dM4n/nixpkgs/ef90a00913b67d6d24485c06cfcd6346796b73d8
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from rissson and jvanbruegge July 22, 2024 14:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 22, 2024
@rissson
Copy link
Member

rissson commented Jul 22, 2024

Upstream fix for scim: goauthentik/authentik#10574

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Jul 23, 2024

The upstream patch is now included.

Thanks to @rissson for handling the upstream change.

@ofborg ofborg bot requested a review from jvanbruegge July 23, 2024 11:13
@pbsbot
Copy link

pbsbot commented Jul 25, 2024

Result of nixpkgs-review pr 329151 run on x86_64-linux 1

1 package built:
  • authentik

@pbsds pbsds merged commit 3099ccf into NixOS:master Jul 25, 2024
25 of 26 checks passed
@B4dM4n B4dM4n deleted the fix-authentik branch July 29, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants