-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mautrix-meta: 0.3.2 -> 0.4.0 #342988
mautrix-meta: 0.3.2 -> 0.4.0 #342988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a cherry-pick of @Rutherther's commit, I'd rather see their authorship information included in the commit message.
0e188db
to
bb19b1f
Compare
That should be reflected now + contained the original commit message. Is this acceptable? Unsure how I should do it any other way :) |
Thank you, I have other stuff at mind these days so I didnt get to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git convention is to use Authored-by: Name Lastname <[email protected]>
, but this is good enough, as you have the author's acknowledgement.
bb19b1f
to
ac1ec4c
Compare
No worries. I was unsure if I should open this PR, and how it might be perceived. Feel free to reach out another time :)
I just used the line from the other PR to get name and email, so that it preserves the original committer. I have however changed the prefix to EDIT: I think I fixed it now in the proper way :) |
This update cannot be done by the nixpkgs bot, as the structure of the project has been changed, so why wait. The mautrix-meta project has been moved under "cmd/mautrix-meta" There is also "cmd/lscli", but since this package is mainly about mautrix-meta, I think we can stay with this specific cmd. If we wanted, we could switch to both of them by removing this `subPackages` attribute.
ac1ec4c
to
9ef2c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but ofborg hasn't built it yet
It's not going to build them because of olm being marked as insecure, I think.
EDIT: I.e. see the other runs https://github.com/NixOS/nixpkgs/pull/342988/checks?check_run_id=30375767936 :) |
Successfully created backport PR for |
Description of changes
Same changes as #342374 , just with correct commit message.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.