vscode-extensions.streetsidesoftware.code-spell-checker-german: init at 2.3.2 #386739
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: vscode
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
drupol
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Hi,
Welcome to the Nix community!
I quickly reviewed your PR and here's my feedback:
- The PR title need work
- I will suggest to create a new file with your extension
- Your PR must only contains 2 commits, no matter which changes you do, make sure to always rebase correctly.
Here's a very recent and similar PR to get some inspiration: #385058
Let me know if you need some help.
Koschi13
force-pushed
the
add-vscode-extensions.streetsidesoftware.code-spell-checker-german
branch
from
bc82155 to
21ca737
Compare
github-actions
bot
added
6.topic: python
6.topic: GNOME
github-actions
bot
removed
6.topic: python
6.topic: GNOME
Koschi13
changed the title
Koschi13
force-pushed
the
add-vscode-extensions.streetsidesoftware.code-spell-checker-german
branch
from
010f403 to
75411cb
Compare
|
Hi @drupol , thanks for the suggestions. I had some problems with the rebase, since I was using the hash from the CONTRIBURING.md. I also rebased now to the master. Please have a look again and thank you. |
drupol
previously requested changes
Mar 4, 2025
Koschi13
force-pushed
the
add-vscode-extensions.streetsidesoftware.code-spell-checker-german
branch
from
75411cb to
1ccf6ca
Compare
|
Can you please fix the casing in the first commit log message? It should be: "maintainers: add koschi13" |
Koschi13
force-pushed
the
add-vscode-extensions.streetsidesoftware.code-spell-checker-german
branch
from
1ccf6ca to
27c8a28
Compare
|
Thank you for your patience and welcome to the Nix community :) Keep PRs coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is my first PR to this project. I tried to add a vs-code extension next to the already existing ones.
If anything is missing or I need to do anything to get this merged please tell me.
I based on the
nixpkgs-unstablehash as written in the CONTRIBUTING.md.The way I tested it was by setting my flake to point to my repository instead of
nixpkgs, I hope that suffices and is correct.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.