Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantainers: add pblgomez #386790

Closed
wants to merge 3 commits into from
Closed

mantainers: add pblgomez #386790

wants to merge 3 commits into from

Conversation

pblgomez
Copy link

@pblgomez pblgomez commented Mar 3, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Pablo Gómez <[email protected]>
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 3, 2025
@drupol
Copy link
Contributor

drupol commented Mar 3, 2025

Hello,

Thank you for your request and your interest in Nix!

Could you please provide some context or motivation behind your request to be added to the maintainer list? Understanding how this aligns with your intentions or contributions to the project would be helpful.

In my opinion, it might be more effective to create a PR that demonstrates why being included in the maintainer list is relevant. For instance:

  • Are you planning to contribute to nixpkgs?
  • Do you intend to adopt and maintain specific packages? In that case, please include the

If your goal is to adopt packages, there's no need for a separate PR for this request. Instead, you can include a commit in a PR where it's clear which packages you'd like to maintain.

This is not about discouraging new contributors—on the contrary! We value new maintainers, and some contextual information will help us streamline the process and support your contributions effectively.

Since this request lacks sufficient context, I will close the PR for now. However, please feel free to open a new PR with more details or reach out if you need any guidance.

Thank you!

@drupol drupol closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants