Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types.functionTo: preserve function argument names #386885

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CertainLach
Copy link
Member

Preserve argument names with functions passed as functionTo without merging (e.g unique).

Makes the following definition work as expected for unique functions, as there is nothing to be "merged" (However I understand that underlying type might do something with merging of a single value itself).

       options.generator = mkOption {
         type = uniq (nullOr (functionTo package));
       ...
       config.generator = {a, b}: false;
       ...
       # Before:
       lib.functionArgs config.generator == {}
       # After:
       lib.functionArgs config.generator == { a = false; }

It would be great to make this behavior only enabled for unique functionTo types, but I don't think there is a way to perform such specialisation?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant