Skip to content

sgx-psw: fix build#403984

Closed
thunze wants to merge 1 commit intoNixOS:masterfrom
thunze:fix-sgx-psw
Closed

sgx-psw: fix build#403984
thunze wants to merge 1 commit intoNixOS:masterfrom
thunze:fix-sgx-psw

Conversation

@thunze
Copy link
Member

@thunze thunze commented May 3, 2025

ZHF: #403336

GCC 14 tracking: #388196, #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thunze
Copy link
Member Author

thunze commented May 3, 2025

Package tests, i.e. NixOS tests for aesmd, are still failing, unfortunately.

I was able to track this down to #356818 but couldn't figure out the exact cause yet.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 3, 2025
@nix-owners nix-owners bot requested review from RealityAnomaly and veehaitch May 3, 2025 19:01
@thunze thunze marked this pull request as draft May 3, 2025 19:01
@thunze
Copy link
Member Author

thunze commented May 12, 2025

I'm going to close this PR for now, as I'm not familiar enough with systemd to fix the failing tests. Sorry!

@thunze thunze closed this May 12, 2025
@thunze thunze deleted the fix-sgx-psw branch May 13, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant