Skip to content

plakar: remove fuse#542244

Open
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:plakar_fuse3
Open

plakar: remove fuse#542244
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:plakar_fuse3

Conversation

@liberodark

@liberodark liberodark commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to : #526161

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested review from heph2, nadir-ishiguro and qbit July 15, 2026 14:07
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 15, 2026
@liberodark

liberodark commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 542244
Commit: c371080514e6af316d00bb073f67acde5c6d3033

x86_64-linux

✅ 1 package built:
  • plakar

@liberodark

liberodark commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 542244
Commit: c371080514e6af316d00bb073f67acde5c6d3033

aarch64-linux

✅ 1 package built:
  • plakar

@mweinelt mweinelt mentioned this pull request Jul 19, 2026
Open
73 tasks
BatteredBunny
BatteredBunny suggested changes Jul 20, 2026
View reviewed changes

@BatteredBunny BatteredBunny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PlakarKorp/plakar/blob/7c63f6b9ff376f02bc9a17abcdb3d2328ea20012/subcommands/mount/fuse/fuse.go#L75
https://github.com/anacrolix/fuse/blob/9b743fba10ace56c49354230287b69310009d3a7/unmount_linux.go#L10

It still tries to use fusermount. Have a look at how #527732 fixed it

@liberodark
liberodark force-pushed the plakar_fuse3 branch 2 times, most recently from 647a710 to ffbcd4f Compare July 20, 2026 10:32
@liberodark
liberodark marked this pull request as draft July 20, 2026 10:33
@liberodark
liberodark force-pushed the plakar_fuse3 branch 2 times, most recently from 4c798c4 to 6d72747 Compare July 21, 2026 09:17
@liberodark

liberodark commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi,

I fixed the issue at the source.
I also alerted the Plakar teams about the fuse2 problem.
I am now waiting for the next Plakar release that fixes this, and I will update this PR in parallel.

Links :

Best Regards

@liberodark
liberodark force-pushed the plakar_fuse3 branch 3 times, most recently from f06d73e to c9cd185 Compare July 23, 2026 12:54
@liberodark
liberodark marked this pull request as ready for review July 23, 2026 12:54
@liberodark
liberodark force-pushed the plakar_fuse3 branch 3 times, most recently from e3ad9ea to a4e96a0 Compare July 23, 2026 13:19
@liberodark

liberodark commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (def992f)

Command: nixpkgs-review pr 542244
Commit: a4e96a01d88d100e159044813a826296652d5315 (subsequent changes)
Merge: dfc221b6393f6a61268cfb3705b7658ecd0e4fa4

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/30010758630/attempts/1

x86_64-linux

✅ 1 package built:
  • plakar

aarch64-linux

✅ 1 package built:
  • plakar

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • plakar

@liberodark

liberodark commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi,

Mount have been validated directly on my stack with this package :

plakar-nixos mount -to /mnt/plakar
info: mounted repository localhost at /mnt/plakar

ls /mnt/plakar
0256d0b9  bb0efff8  bb47873c  f4d356e9

Best Regards

BatteredBunny
BatteredBunny reviewed Jul 23, 2026
View reviewed changes
Comment thread pkgs/by-name/pl/plakar/package.nix
@liberodark

liberodark commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (def992f)

Command: nixpkgs-review pr 542244
Commit: 8af4a236d92bf4bb55a1c068909da4e82973ad5c (subsequent changes)
Merge: c870aba9926e2f2c0fb7b922d8fa85fc50a98c4a

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/30048018311/attempts/1

x86_64-linux

✅ 1 package built:
  • plakar

aarch64-linux

✅ 1 package built:
  • plakar

x86_64-darwin

✅ No rebuilds

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • plakar

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heph2 heph2 Awaiting requested review from heph2
@nadir-ishiguro nadir-ishiguro Awaiting requested review from nadir-ishiguro
@qbit qbit Awaiting requested review from qbit
1 more reviewer
@BatteredBunny BatteredBunny BatteredBunny approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liberodark @BatteredBunny