-
Notifications
You must be signed in to change notification settings - Fork 3
Prompt 컴포넌트 리팩토링 및 배경 이미지 오류, Storybook 이미지 오류 수정 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
69951da
:recycle: screen constants 추가
nijesmik 61e0532
:recycle: prompt 컴포넌트 분리 및 위치 이동 #57
nijesmik 4693890
:lipstick: 배경 이미지 사이즈 cover로 변경 #14
nijesmik b392310
:necktie: ImageBox 컴포넌트 이미지를 div의 background가 아닌 img 태그로 처리 #33
nijesmik 665af57
:bug: 스토리북 이미지를 상대경로로 변경 #51
nijesmik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| import { vars } from '@/styles/vars.css'; | ||
|
|
||
| import { IPHONE_14_PRO_MAX, IPHONE_SE } from '@/constants/screen'; | ||
|
|
||
| export const FRAME_STYLE = { | ||
| width: { | ||
| max: '932px', // iphone 14 pro max | ||
| min: '667px', // iphone se | ||
| max: IPHONE_14_PRO_MAX.width, | ||
| min: IPHONE_SE.width, | ||
| }, | ||
| height: { | ||
| max: '431px', | ||
| min: '320px', | ||
| max: IPHONE_14_PRO_MAX.height, | ||
| min: IPHONE_SE.height, | ||
| }, | ||
| padding: vars.space['4x'], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { style } from '@vanilla-extract/css'; | ||
|
|
||
| import { sprinkles } from '@/styles/sprinkles.css'; | ||
|
|
||
| import { IPHONE_SE } from '@/constants/screen'; | ||
|
|
||
| export const fullscreenPromptStyle = style([ | ||
| sprinkles({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| width: 'full', | ||
| height: 'full', | ||
| zIndex: 'alert-content', | ||
| position: 'fixed', | ||
| }), | ||
| { | ||
| backgroundRepeat: 'no-repeat', | ||
| backgroundPosition: 'center', | ||
| backgroundSize: 'cover', | ||
| backgroundImage: | ||
| 'url(/images/background/background-white-large-h991w1922.webp)', | ||
| overlay: 'auto', | ||
| top: 0, | ||
| left: 0, | ||
|
|
||
| '@media': { | ||
| [`screen and (min-width: ${IPHONE_SE.width})`]: { | ||
nijesmik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| display: 'none', | ||
| }, | ||
| }, | ||
| }, | ||
| ]); | ||
|
|
||
| export const fullscreenPromptText = style([ | ||
| { | ||
| textAlign: 'center', | ||
| fontSize: '40px', | ||
| lineHeight: '48px', | ||
| textShadow: '-3px 0px white, 0px 3px white, 3px 0px white, 0px -3px white', | ||
| }, | ||
| ]); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import * as styles from './index.css'; | ||
|
|
||
| const FullscreenPrompt = () => { | ||
| return ( | ||
| <div className={styles.fullscreenPromptStyle}> | ||
| <p className={styles.fullscreenPromptText}>!! 주의 !!</p> | ||
| <p className={styles.fullscreenPromptText}>{'<가로 모드>를'}</p> | ||
| <p className={styles.fullscreenPromptText}>장착하세요!</p> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default FullscreenPrompt; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
altprop is optional but no default value is provided. Whenaltis undefined, screen readers will announce the image filename, which may not be meaningful. Consider providing a default empty string for decorative images:alt={alt ?? ''}.