Skip to content

chore(deps): pin solx-llvm to the direct Sol-to-Yul lowering - #947

Merged
hedgar2017 merged 1 commit into
mainfrom
app-sol-to-yul-direct
Nov 18, 2026
Merged

hedgar2017 merged 1 commit into
mainfrom
app-sol-to-yul-direct

Conversation

@abinavpp

Copy link
Copy Markdown
Contributor

@abinavpp abinavpp added ci:integration Trigger integration tests workflow on PR ci:sourcify-sweep Run Sourcify corpus on this PR labels Nov 17, 2026
@abinavpp
abinavpp marked this pull request as ready for review November 17, 2026 22:15
@github-actions

Copy link
Copy Markdown

Coverage Summary

Crate Line Coverage Function Coverage
solx 🟢 83.8% 🔴 20.0%
solx-benchmark-converter 🔴 0.0% 🔴 0.0%
solx-codegen-evm 🟡 56.6% 🟡 51.5%
solx-compiler-downloader 🔴 0.0% 🔴 0.0%
solx-core 🔴 47.2% 🟡 58.8%
solx-dev 🔴 2.2% 🔴 2.1%
solx-mlir 🔴 48.5% 🔴 48.2%
solx-slang 🔴 30.5% 🔴 34.7%
solx-solc-test-adapter 🔴 1.7% 🔴 2.1%
solx-standard-json 🔴 38.8% 🔴 42.5%
solx-tester 🔴 36.6% 🔴 34.6%
solx-utils 🔴 44.7% 🔴 45.2%
Total 🔴 13.2% 🔴 16.5%

Codecov Report | HTML Report | Workflow Run

@hedgar2017 hedgar2017 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

Copy link
Copy Markdown

Compile-time benchmark (--standard-json)

pr: slang v0.2.0, LLVM-based Solidity compiler for the EVM, Front end: Slang, LLVM build: ab57e54b6a26e1d2a2f452e12756e1530fb990d1
main: slang v0.2.0, LLVM-based Solidity compiler for the EVM, Front end: Slang, LLVM build: b385f75d248ef6c26dd3880981f3b48096c0d879
prerelease: slang v0.2.0, LLVM-based Solidity compiler for the EVM, Front end: Slang, LLVM build: 716613b727e0de5b086556ca69b475aa3e496c06
runner: solx-bench-lon-1
commits: pr 369fe249 merged into main, main 603e6737

ens-verifiable-factory-solx--solx-legacy-dwarf

binary median mean ± σ min … max vs baseline
pr 0.227 s 0.227 s ± 0.004 s 0.220 s … 0.231 s 0.981×
main 0.231 s 0.231 s ± 0.005 s 0.224 s … 0.240 s 1.000×
prerelease 0.433 s 0.435 s ± 0.007 s 0.428 s … 0.451 s 1.871×

openzeppelin-contracts-0.34--solx-legacy-dwarf

binary median mean ± σ min … max vs baseline
pr 1.731 s 1.731 s ± 0.004 s 1.724 s … 1.738 s 0.969×
main 1.787 s 1.786 s ± 0.008 s 1.774 s … 1.802 s 1.000×
prerelease 2.932 s 2.933 s ± 0.016 s 2.906 s … 2.964 s 1.641×

uniswap-v4-core-solx--solx-legacy-dwarf

binary median mean ± σ min … max vs baseline
pr 0.713 s 0.713 s ± 0.010 s 0.700 s … 0.728 s 0.985×
main 0.724 s 0.725 s ± 0.010 s 0.712 s … 0.741 s 1.000×
prerelease 1.877 s 1.879 s ± 0.022 s 1.854 s … 1.909 s 2.591×

@github-actions

Copy link
Copy Markdown

🧪 Integration tests — standard · PR vs main

✅ Output-preserving — bytecode size identical (28,638 comparisons), solx-tester gas identical (36,849).
✅ No new failures — Foundry's 410 failures already present on main.

Suite New failures Size Δ Gas Δ Report
solx-tester ✅ 0 ✅ 0 of 26,774 ✅ 0 of 36,849 solx-tester-report.xlsx ↓
Foundry · 26 proj ✅ 0 (410 pre-existing) ✅ 0 of 1,864 ⚪ jitter 12 of 3,303, median <0.1% (not gated) foundry-report.xlsx ↓
Hardhat · 3 proj ✅ 0 ⚪ not collected ⚪ not collected hardhat-report.xlsx ↓

Compile time — wall-clock tripwire, positive = PR slower (authoritative Δ in the compile-time benchmark comment)

Suite legacy (agg / median)
Foundry · 26 proj -2.4% / -2.0%
Hardhat · 3 proj +3.4% / +2.2%

⚠️ Project outliers (≥15%): hardhat-v3 legacy +44.4%

@hedgar2017
hedgar2017 added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit b205ce9 Nov 18, 2026
87 of 92 checks passed
@hedgar2017
hedgar2017 deleted the app-sol-to-yul-direct branch November 18, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:integration Trigger integration tests workflow on PR ci:sourcify-sweep Run Sourcify corpus on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants