fix: use Exception instead of BaseException in atomic_json_write#1009
Open
hiSandog wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: use Exception instead of BaseException in atomic_json_write#1009hiSandog wants to merge 1 commit intoNousResearch:mainfrom
hiSandog wants to merge 1 commit intoNousResearch:mainfrom
Conversation
- BaseException catches KeyboardInterrupt and SystemExit which is not ideal - Using Exception allows proper signal handling and graceful shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical issue where BaseException was being caught instead of Exception in the atomic_json_write function.
Problem
Catching BaseException is generally a bad practice because it catches system-exiting exceptions like KeyboardInterrupt and SystemExit, which should typically propagate.
Changes
Impact