feat: restore ACP server implementation that was missed from PR #949#1254
Merged
feat: restore ACP server implementation that was missed from PR #949#1254
Conversation
Restore the ACP editor-integration implementation that was present on the original PR branch but did not actually land in main. Includes: - acp_adapter/ server, session manager, event bridge, auth, permissions, and tool helpers - hermes acp subcommand and hermes-acp entry point - hermes-acp curated toolset - ACP registry manifest, setup guide, and ACP test suite - jupyter-live-kernel data science skill from the original branch Also updates the revived ACP code for current main by: - resolving runtime providers through the modern shared provider router - binding ACP sessions to per-session cwd task overrides - tracking duplicate same-name tool calls with FIFO IDs - restoring terminal approval callbacks after prompts - normalizing supporting docs/skill metadata Validated with tests/acp and the full pytest suite (-n0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainacp_adapter/package, ACP registry manifest, setup guide, ACP test suite, andhermes acp/hermes-acpentrypointshermes-acptoolset and thejupyter-live-kerneldata science skill that shipped with the original ACP branchWhy this PR exists
PR #949's body described the ACP implementation, but the merge commit that landed on
mainonly contained the cron timezone fix. The ACP files were still present on the PR branch history (cc61f54,3441911) but never made it intomain.This PR restores those missing ACP changes on top of current
main.Additional review/fixes applied while restoring ACP
I did not lift the old branch verbatim. I reviewed it against current
mainand updated it to fit the modern runtime:acp_adapter/auth.pyacpextra,hermes-acpscript, andacp_adapterpackage discovery)Test plan
source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/acp/ -n0 -qsource /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/ -n0 -qsource /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m hermes_cli.main acp --helpResults: