test(cron): add cross-timezone naive timestamp regression#1319
Merged
Conversation
Cherry-picked from PR #1308 by 0xNyk. Adds an end-to-end regression test covering a Hermes timezone far behind system local time (Pacific/Midway, UTC-11) to ensure legacy naive cron timestamps are still recognized as due under large timezone mismatches.
This was referenced Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pacific/Midwayto cover a large Hermes-vs-system timezone mismatchTest plan
python -m pytest tests/test_timezone.py::TestCronTimezone::test_get_due_jobs_naive_cross_timezone -n0 -qpython -m pytest tests/test_timezone.py tests/cron/test_jobs.py tests/tools/test_cronjob_tools.py -n0 -qpython -m pytest tests/ -n0 -qFollow-up to PR #949.
Salvages the remaining useful test coverage from PR #1308 and supersedes PR #929 for this topic.