Skip to content

fix: resolve delegation providers from custom_providers#1328

Merged
teknium1 merged 2 commits intomainfrom
hermes/hermes-ec1096a3
Mar 14, 2026
Merged

fix: resolve delegation providers from custom_providers#1328
teknium1 merged 2 commits intomainfrom
hermes/hermes-ec1096a3

Conversation

@teknium1
Copy link
Contributor

@teknium1 teknium1 commented Mar 14, 2026

Summary

  • salvage PR fix: resolve delegation providers from custom_providers #1012 onto current main by cherry-picking the contributor's runtime-provider fix with authorship preserved
  • resolve delegation providers from config.yaml custom_providers when delegation uses either the raw saved name (for example local) or the menu-key form (custom:local)
  • keep raw custom names from shadowing built-in provider ids like nous
  • keep the regression coverage aligned with current main while retaining tests for saved credentials, env fallback, and builtin-vs-custom precedence

Test plan

  • python -m pytest tests/test_runtime_provider_resolution.py tests/test_api_key_providers.py tests/tools/test_delegate.py -n0 -q
  • python -m pytest tests/ -n0 -q

Closes #1011
Salvages #1012

dadi-sisi and others added 2 commits March 14, 2026 11:19
Follow up on salvaged PR #1012.
Prevents raw custom-provider names from intercepting built-in provider ids,
and keeps the regression coverage focused on current-main behavior.
@teknium1 teknium1 merged commit 588d4c2 into main Mar 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: agent delegation to custom inference provider does not work

2 participants