feat(memory): Graphnosis local memory provider + MCP catalog entry#51197
feat(memory): Graphnosis local memory provider + MCP catalog entry#51197nehloo wants to merge 1 commit into
Conversation
|
Validation so far (Nehloo Interactive / Graphnosis)
Happy to run any extra checks maintainers want (live hermes memory setup, hermes mcp install graphnosis, etc.). |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Overview
New memory provider plugin: Graphnosis local memory + MCP catalog entry. Implements a local memory system with MCP server for external agent integration.
Analysis
- 11 files all scoped to the new memory provider (plugin, CLI, client, MCP manifest, docs, sidebar)
- Well-structured plugin architecture:
__init__.py,cli.py,client.py,plugin.yaml,README.md - MCP catalog entry allows use with Claude Code, Codex, Gemini CLI
- Includes dedicated test file:
tests/agent/test_graphnosis_memory_provider.py - Documentation added:
website/docs/user-guide/integrations/graphnosis.mdand memory-providers.md updated
Looks Good
- Clean, well-scoped new feature
- Follows existing plugin architecture patterns
- Good test coverage
- Good documentation
Reviewed by Hermes Agent
|
Companion Hermes Desktop UI PR is up: fathah/hermes-desktop#763 Adds Memory provider copy + download link, Capabilities → MCP install promo ( Depends on this agent PR for the manifest + memory plugin. Local validation: |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
New Graphnosis local memory provider: a file-based memory store with MCP (Model Context Protocol) catalog entry, local document ingestion, and session management. 11 files, +767/-4.
Changes
plugins/memory/graphnosis/__init__.py,client.py,cli.py: Core Graphnosis implementationplugins/memory/graphnosis/README.md,plugin.yaml: Documentation and plugin manifesttests/agent/test_graphnosis_memory_provider.py: +75 lines test coverage- Documentation updates for memory-providers and integrations
Quality
- 11 files — just below the 15-file high-surface-area threshold
- Good test coverage for core functionality
- No security concerns
Reviewed by Hermes Agent
|
Hi — gentle nudge on this PR when you have a moment. It adds Graphnosis as a local encrypted memory provider ( Validated: Two bot reviews are in; branch shows mergeable but blocked pending a human maintainer. Is anything else needed before merge, or could someone from the Nous team take a look? Happy to run live checks ( |
|
Thanks for the substantial Graphnosis integration work, including the MCP catalog manifest, setup documentation, and the companion Desktop work referenced in the PR discussion. This automated hermes-sweeper review is closing it under the standing memory-provider policy:
Please publish the provider as a standalone plugin repository or pip entry point and share it through the Nous Research Discord Closed as not-planned per standing maintainer policy ( |
Summary
Adds Graphnosis as a local encrypted memory provider and MCP catalog entry for Hermes.
graphnosis_recall,graphnosis_remember,graphnosis_statshermes mcp install graphnosis→ fullmcp_graphnosis_*tool surfaceBoth connect to the Graphnosis desktop app via
~/.graphnosis/mcp.sockusing the published npm relay@graphnosis/mcp-relay(Apache-2.0). No API key; cortex must be unlocked.Reference bundle: https://github.com/nehloo-interactive/graphnosis-app/tree/main/integrations/hermes-agent
Changes
plugins/memory/graphnosis/— provider plugin + CLI (hermes graphnosis status, etc.)optional-mcps/graphnosis/manifest.yaml— catalog entryhermes_cli/mcp_config.py—graphnosispresettests/agent/test_graphnosis_memory_provider.pyintegrations/graphnosis.md, Graphnosis section inmemory-providers.md, sidebar entryTest plan
pytest tests/agent/test_graphnosis_memory_provider.py -q— 5 passedhermes memory setuplists graphnosishermes mcp catalog | grep -i graphnosishermes mcp install graphnosis→ new session exposesmcp_graphnosis_*toolshermes graphnosis statuswhen provider activeNotes
Graphnosis also ships a Get Connected → Hermes wizard that writes the same
~/.hermes/config.yamlshape; this PR makes setup discoverable via native Hermes flows.Maintained by Nehloo Interactive LLC (
nehloo-interactive/graphnosis-app).