Skip to content

fix(cli): support Shift+Enter for newline in modern terminals #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZealousEar wants to merge 1 commit into from
Closed

fix(cli): support Shift+Enter for newline in modern terminals #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
from prompt_toolkit.layout.menus import CompletionsMenu
from prompt_toolkit.widgets import TextArea
from prompt_toolkit.key_binding import KeyBindings
from prompt_toolkit.input.vt100_parser import ANSI_SEQUENCES
from prompt_toolkit.keys import Keys
from prompt_toolkit import print_formatted_text as _pt_print
from prompt_toolkit.formatted_text import ANSI as _PT_ANSI
import threading
Expand Down Expand Up @@ -1806,7 +1808,7 @@ def show_help(self):
_cprint(f" {_GOLD}{cmd:<22}{_RST} {_DIM}-{_RST} {info['description']}")

_cprint(f"\n {_DIM}Tip: Just type your message to chat with Hermes!{_RST}")
_cprint(f" {_DIM}Multi-line: Alt+Enter for a new line{_RST}")
_cprint(f" {_DIM}Multi-line: Shift+Enter, Alt+Enter, or Ctrl+Enter{_RST}")
_cprint(f" {_DIM}Paste image: Alt+V (or /paste){_RST}\n")

def show_tools(self):
Expand Down Expand Up @@ -3340,6 +3342,13 @@ def handle_enter(event):
self._pending_input.put(payload)
event.app.current_buffer.reset(append_to_history=True)

# Shift+Enter via Kitty keyboard protocol (Ghostty, Kitty, WezTerm, etc.)
# These terminals send distinct escape sequences for Shift+Enter, but
# prompt_toolkit maps them to plain ControlM (Enter). Remap them to
# ControlJ so they insert a newline instead of submitting.
ANSI_SEQUENCES['\x1b[27;2;13~'] = Keys.ControlJ # xterm modifyOtherKeys
ANSI_SEQUENCES['\x1b[13;2u'] = Keys.ControlJ # CSI u / Kitty protocol

@kb.add('escape', 'enter')
def handle_alt_enter(event):
"""Alt+Enter inserts a newline for multi-line input."""
Expand Down Expand Up @@ -3466,8 +3475,6 @@ def handle_ctrl_d(event):
self._should_exit = True
event.app.exit()

from prompt_toolkit.keys import Keys

@kb.add(Keys.BracketedPaste, eager=True)
def handle_paste(event):
"""Handle terminal paste — detect clipboard images.
Expand Down