fix(setup): preserve provider metadata during model selection#856
Closed
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(setup): preserve provider metadata during model selection#856kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Conversation
1 task
Contributor
|
Merged via 4525933. Thanks @kshitijk4poor — thorough fix with good test coverage. Audited the rest of the codebase for the same stale-config-overwrite pattern:
The bug was fully isolated to setup.py. Your fix covers all 9 provider paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modelconfig instead of being clobbered by the finalsave_config(config)Root cause
During
hermes setup, provider selection updatedconfig.yamldirectly via_update_config_for_provider(...), but later the wizard saved a stale in-memoryconfigobject back to disk. That final save could dropmodel.provider/model.base_url(and in the OAuth keep-current path,model.default), leaving fresh installs misconfigured.Test plan
python -m pytest tests/hermes_cli/test_setup.py tests/test_auth_nous_provider.py tests/test_cli_provider_resolution.py tests/hermes_cli/test_config.py -qpython -m pytest tests/ -q -k \"not vision_tools\"Issue
Closes #853