fix(skills): distinguish local skills from builtin in 'skills list'#869
Open
Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(skills): distinguish local skills from builtin in 'skills list'#869Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Previously, any skill not installed via hub was labeled as 'builtin', which was inaccurate for user-provided local skills (e.g., from ~/.hermes/skills/). This fix: - Reads the bundled manifest to identify true builtins - Labels non-hub, non-builtin skills as 'local' - Adds --source local filter support - Updates CLI help text Fixes NousResearch#861
|
Thanks for tackling this — this is the same bug tracked in #861, which I already fixed in PR #862 with the same source-classification behavior (hub/builtin/local) plus tests.
Since #869 overlaps #862 and currently does not include tests, I suggest closing #869 in favor of #862 to avoid duplicate review/merge work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
hermes skills listlabeled any skill not installed via hub as 'builtin', which was inaccurate for user-provided local skills (e.g., from ~/.hermes/skills/).This fix:
tools.skills_sync._read_manifest()--source localfilter supportFixes #861