fix: backfill model on gateway sessions after agent runs#988
Closed
heyalchang wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: backfill model on gateway sessions after agent runs#988heyalchang wants to merge 1 commit intoNousResearch:mainfrom
heyalchang wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Adds optional `model` param to `update_token_counts()` and `update_session()`. Both return dicts in `_run_agent()` now include `agent.model`, and `_handle_message()` passes it through so gateway sessions no longer have NULL model in the DB. Closes NousResearch#987 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Superseded by #997 — cleaner implementation (single COALESCE query, no whitespace noise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #987.
After
_run_agent()finishes,agent.modelis available but was never written back to the sessions table. This PR threads the model through the return dict and intoupdate_session()/update_token_counts(), usingCOALESCEso it only fills NULL — never overwrites a model already set.