-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify build scripts; build.sh & build-src.sh #4341
base: dev
Are you sure you want to change the base?
Conversation
98186f4
to
d121c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duncanbeevers Great work, and definitely going into the right direction!
Unfortunately the dev
branch is behind the main
branch regarding the build process, so it may be easier to retarget to or restart from main
, where for example the whole "history" magic has been removed in favor of static *-editors.md
files accompanying each specification version file.
Sorry for the inconvenience!
As the
|
eb7b162
to
842b69f
Compare
build.sh with no arguments operates the same; builds all versions to /deploy build.sh with version argument builds single version to /deploy-preview build.sh with "latest" argument builds latest version to /deploy-preview build.sh with "oas" argument builds from src/oas.md to /deploy-preview
842b69f
to
9c02f33
Compare
@ralfhandl I've removed the |
@ralfhandl The |
Resolve Google Analytics snippet location relative to md2html.js Update tests to reflect inclusion of snippet Pre-requisite to OAI#4341
build.sh with no arguments builds all versions build.sh <version> builds single version build.sh latest builds latest version build.sh src builds from src/oas.md Resolve Google Analytics snippet location relative to md2html.js Update tests to reflect inclusion of snippet Pre-requisite to OAI#4341
build.sh with no arguments builds all versions build.sh <version> builds single version build.sh latest builds latest version build.sh src builds from src/oas.md Resolve Google Analytics snippet location relative to md2html.js Update tests to reflect inclusion of snippet Pre-requisite to OAI#4341
Actually we don't need/want
|
@duncanbeevers This PR only contains variations of changes that have already been merged to We still need
Would you like to create that second PR? |
🗣️ Discussion
This PR depends on #4342 and #4344, per this comment.
This PR supersedes #4340.
In the
dev
branch there are two implementations of the build process.build-src
implementation, which builds fromsrc/oas.md
into/deploy-preview
versions/*.md
into/deploy/oas
Each implementation conducts its clean-up slightly differently, and the CI-focused implementation does some housework around generating MAINTAINERS files to accompany older specification versions.
This PR combines the two kinds of functionality into a single script.
Notable non-changes
build.sh
with no arguments, and hence CI, continues to operate as before, generating the full suite of documentation and symlinksnpm run build
andnpm run build-src
continue to operate as before, generating the suite, and thesrc/oas.md
documentation, respectively.Notable changes
🥬 indicates New capabilities
⚡ indicates Departures from old behavior or assumptions
🚧 indicates Reverted changes
npm run build 3.1.1
with a single version argument builds the documentation for the specified versionnpm run build latest
builds the documentation for the last-tagged versionnpm run build src
builds the documentation for thesrc/oas.md
specificationcd
,pushd
, andpopd
calls are removed/scripts/md2html/md2html.js
loads Google Analytics scripts, regardless of the$cwd
; tests are updated/deploy/js
is removed during cleanup/history
directory containing historicalMAINTAINERS.md
versions is created at repository root/history
is removed during cleanupI validated that the tests pass (and were updated to include the Google Analytics snippet).
I also validated that all the produced artifacts in this PR are identical to their counterparts from the
dev
branch, including:npm run build-src
creates identical/deploy-preview/oas.html
npm run build
creates identical/deploy/oas/
, including file names, content, and symlink referencesChecklist