-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.2: XML Object example updates #4711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.2-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, one suggestion
Co-authored-by: Ralf Handl <[email protected]>
@@ -3274,46 +3274,85 @@ For examples using `attribute` or `wrapped`, please see version 3.1 of the OpenA | |||
|
|||
###### No XML Object | |||
|
|||
Basic string property (`nodeType` is `element` by default): | |||
Basic string property without an XML Object, using `serializedValue` (the remaining examples will use `externalValue` so that the XML form can be shown with syntax highlighting): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am I right in thinking the serializedValue PR would be a dependency of this PR? (no drama if it is, we just need to make sure to review the other one first)
For the new Example Object fields.