Official 3.2.0 release branch #4970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-parameter 3.2: removes the OAS reference object from headers schema definition
Since we are testing with a placeholder, we need to match the placeholder. This will unfortunately need to be different on each new release line branch, so let's separate this test case into its own file.
Also make the discriminator usage valid.
Test Schema Object extension fields on v3.2-dev
Clarifies that the name of the root XML element comes from the component name, which was shown in an example but was unclear due to the use of the obsolete OAS 2.0 terminology "model." This does not change the restriction (in the `xml` field of the Schema Object) that the `xml` field only applies to property schemas (and not root schemas).
This avoids reinforcing the "root schema" vs "property schema" restriction that we plan to relax.
This change adds a nodeType field to support the four most commonly used XML node types: element, attribute, text, and cdata. A fifth nodetype, none, is used to prevent a Schema Object from producing a node. This also removes the restriction on where the xml field and XML Object can appear, as the nodeType system is more flexible than the old system. This deprecates two existing fields: * attribute, replaced by nodeType: attribute * wrapped, replaced by nodeType: none
Co-authored-by: Ralf Handl <[email protected]>
There really isn't a native `null` type in XML, as both elements and attributes that are empty have an empty string value. We also need to leave the behavior implementation-defined for compatibility. However, the `xsi:nil` attribute is the closest thing to a `null` element. Attributes are harder, and the best I can come up with is letting `null` behave the same as an omitted attribute for the purpose of serialization.
The guidance is the same as for serializing `null` and other non-text data types to text in other text-based media types such as the form media types.
Co-authored-by: Ralf Handl <[email protected]>
v3.2: Support all common XML node types (element, attribute, text, cdata)
v3.2: Strengthen generic data types to a SHOULD
Co-authored-by: Ralf Handl <[email protected]>
Since we are testing with a placeholder, we need to match the placeholder. This will unfortunately need to be different on each new release line branch, so let's separate this test case into its own file.
lornajane
dismissed stale reviews from ralfhandl, mikekistler, and earth2marsh
via
de2325a
ralfhandl
previously approved these changes
Sep 19, 2025
lornajane
dismissed
ralfhandl’s stale review
The merge-base changed after approval.
earth2marsh
previously approved these changes
Sep 19, 2025
|
Approved |
lornajane
dismissed
earth2marsh’s stale review
The merge-base changed after approval.
earth2marsh
previously approved these changes
Sep 19, 2025
lornajane
dismissed
earth2marsh’s stale review
The merge-base changed after approval.
ralfhandl
previously approved these changes
Sep 19, 2025
lornajane
dismissed
ralfhandl’s stale review
The merge-base changed after approval.
ralfhandl
approved these changes
Sep 19, 2025
ralfhandl
previously approved these changes
Sep 19, 2025
lornajane
dismissed
ralfhandl’s stale review
The merge-base changed after approval.
ralfhandl
previously approved these changes
Sep 19, 2025
lornajane
dismissed
ralfhandl’s stale review
The merge-base changed after approval.
ralfhandl
approved these changes
Sep 19, 2025
earth2marsh
approved these changes
Sep 19, 2025
|
🎉🎉🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official candidate release for the 3.2.0 version of OpenAPI Specification.
@OAI/tsc please comment with your vote. The vote remains open for 7 days (until September 25th)
The release notes are available in the summary release notes in #4600