[DRAFT] Migrate to new shared build infrastructure.#5424
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
handrews
force-pushed
the
shared-infra
branch
2 times, most recently
from
cb6896e to
f159e14
Compare
|
Some failures were due to a platform-specific dependency installation problem. This has been fixed, and the issue has been documented in the build-infra repository with the instructions on setting up repos to use the shared infrastructure. The last failure was due to linkspector checking a link to a build-infra markdown file that is not yet on main, so I added it to the exclusion list temporarily. I'll remove that commit from this branch before taking this out of draft, assuming we decide this PR is worth reviewing in its current form. |
Co-authored-by: Codex <codex@openai.com>
...because CONTRIBUTING.md is not on main yet, and we want the draft PR to pass CI. This commit should be removed from the branch before taking the PR out of draft.
| "markdownlint-cli2": "^0.22.1", | ||
| "vitest": "^4.0.1", | ||
| "yaml": "^2.9.0" | ||
| "@oai/build-infra": "git+https://github.com/OAI/build-infra.git#main" |
There was a problem hiding this comment.
I think git installs are going to be disabled by default with npm 12 for security reasons. Maybe some we want to account for in the workflows here?
There was a problem hiding this comment.
From what I understand, we will just need to pass --allow-git=all
We definitely do not want to publish this package to npm.
2 participants
This Codex-authored draft pull request is the companion to OAI/build-infra#1 and MUST NOT be merged until after that PR has been merged, and until after we have proven that the new system works with OAI/sig-lifecycle#1. I am posting it here purely to illustrate the impact so the complete approach can be considered. See OAI/build-infra#1 for full context and a discussion of the use of AI and how to review these changes.
This might try to run CI which may or may not work given the state of OAI/build-infra. I'll look into any failures and either explain them or fix them prior to marking this ready to review.
This new system pushes all dependency management into the build-infra repository, eliminating the continual flood of dependabot updates and branch syncs we are currently experiencing. It also makes it trivial to set up the SIG repositories for specificaiton publishing.