Skip to content

[19.0][OU-ADD] partnership: Migration scripts - #5882

Merged
pedrobaeza merged 1 commit into
OCA:19.0from
HeliconiaIO:19.0-mig-partnership
Aug 5, 2026
Merged

[19.0][OU-ADD] partnership: Migration scripts#5882
pedrobaeza merged 1 commit into
OCA:19.0from
HeliconiaIO:19.0-mig-partnership

Conversation

@BhaveshHeliconia

@BhaveshHeliconia BhaveshHeliconia commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels Aug 5, 2026
@BhaveshHeliconia
BhaveshHeliconia marked this pull request as draft August 5, 2026 06:52
@BhaveshHeliconia
BhaveshHeliconia marked this pull request as ready for review August 5, 2026 07:20
@MiquelRForgeFlow MiquelRForgeFlow added this to the 19.0 milestone Aug 5, 2026
@MiquelRForgeFlow

MiquelRForgeFlow commented Aug 5, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/ocabot migration partnership

Depends on :

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 5, 2026
Open
@github-actions github-actions Bot mentioned this pull request Aug 5, 2026
Draft
MiquelRForgeFlow
MiquelRForgeFlow reviewed Aug 5, 2026
View reviewed changes
Comment thread openupgrade_scripts/apriori.py Outdated
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 19.0-mig-partnership branch 2 times, most recently from 3673526 to 742fd50 Compare August 5, 2026 11:34
MiquelRForgeFlow
MiquelRForgeFlow reviewed Aug 5, 2026
View reviewed changes
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/pre-migration.py Outdated
pedrobaeza
pedrobaeza requested changes Aug 5, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want partnership module as replacement of membership. They are different things. membership has been moved to OCA, so please don't do any of this.

MiquelRForgeFlow
MiquelRForgeFlow reviewed Aug 5, 2026
View reviewed changes
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/pre-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
Comment thread openupgrade_scripts/scripts/partnership/19.0.1.0/post-migration.py Outdated
@MiquelRForgeFlow

MiquelRForgeFlow commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

We don't want partnership module as replacement of membership. They are different things. membership has been moved to OCA, so please don't do any of this.

Wrong. This PR is not a replacement. partnership can be a dependency of a module you have installed, like website_crm_partner_assign. Thus, you must need partnership and this PR handles this.

@BhaveshHeliconia

BhaveshHeliconia commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

We don't want partnership module as replacement of membership. They are different things. membership has been moved to OCA, so please don't do any of this.

Thanks for the clarification! @pedrobaeza, I've removed all membership-related migration logic. The PR now only handles the XML ID renames from website_crm_partner_assign to partnership, which is needed since partnership is a dependency of website_crm_partner_assign in 19.0.

@BhaveshHeliconia

BhaveshHeliconia commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@MiquelRForgeFlow Thanks for the suggestion and guidance!

@pedrobaeza
pedrobaeza merged commit d5ea8a9 into OCA:19.0 Aug 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees

No one assigned

Labels

approved Dependency OK mod:openupgrade_scripts Module openupgrade_scripts series:19.0

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@BhaveshHeliconia @MiquelRForgeFlow @pedrobaeza @OCA-git-bot