Skip to content

[18.0][IMP] account_credit_control: Report custom text fields in html - #514

Open
qgroulard wants to merge 1 commit into
OCA:18.0from
acsone:18.0-credit_control_report_custom_text_html-qgr
Open

[18.0][IMP] account_credit_control: Report custom text fields in html#514
qgroulard wants to merge 1 commit into
OCA:18.0from
acsone:18.0-credit_control_report_custom_text_html-qgr

Conversation

@qgroulard

@qgroulard qgroulard commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Forward port of #64

The aim of these two fields is to be injected in reports, thus it seems more convenient to me to have them in HTML.

pedrobaeza
pedrobaeza reviewed Oct 29, 2025
View reviewed changes
Comment thread account_credit_control/migrations/18.0.2.1.0/post-migration.py Outdated
]
},
)
openupgrade.convert_field_to_html(

@pedrobaeza pedrobaeza Oct 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happen if coming from 17 having these fields already in HTML?

@qgroulard qgroulard Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I have added a check

@qgroulard
qgroulard force-pushed the 18.0-credit_control_report_custom_text_html-qgr branch from c542ea9 to bf8454f Compare October 29, 2025 14:10
@pedrobaeza pedrobaeza added this to the 18.0 milestone Oct 29, 2025
@pedrobaeza

pedrobaeza commented Oct 29, 2025

Copy link
Copy Markdown
Member

Please include the module name in the commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@qgroulard
qgroulard force-pushed the 18.0-credit_control_report_custom_text_html-qgr branch 2 times, most recently from e49a9cb to e9c8678 Compare October 30, 2025 11:23
@pedrobaeza pedrobaeza changed the title [18.0][IMP] Report custom text fields in html [18.0][IMP] account_credit_control: Report custom text fields in html Oct 30, 2025
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 1, 2026
@qgroulard
qgroulard force-pushed the 18.0-credit_control_report_custom_text_html-qgr branch from e9c8678 to 0122a36 Compare March 2, 2026 12:11
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 12, 2026
samirGuesmi
samirGuesmi approved these changes Jul 13, 2026
View reviewed changes

@samirGuesmi samirGuesmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+2 more reviewers
@samirGuesmi samirGuesmi samirGuesmi approved these changes
@baimont baimont baimont approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@qgroulard @pedrobaeza @OCA-git-bot @samirGuesmi @baimont