[19.0] [MIG] account_invoice_overdue_reminder: Migration to 19.0 - #560
[19.0] [MIG] account_invoice_overdue_reminder: Migration to 19.0#560stferraro wants to merge 116 commits into
Conversation
…instead of supplier invoice form
…update your mail templates) Add ability to add contacts as Cc of the reminder email (added to the Cc of the mail template) Add partner_policy with 3 options to give some choice about which contact should be selected to send reminders Access reminders from partner via Action menu
Advantages: 1) easy access to the history in the chatter of the partner. 2) no problem to access the email by other users (avoid "The requested operation cannot be completed due to security restrictions. Please contact your system administrator.")
Co-authored-by: ypapouin <y.papouin@dec-industrie.com>
Co-authored-by: ypapouin <y.papouin@dec-industrie.com>
…e customer invoices Move "Send overdue reminder" button to the alter banner.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-14.0/credit-control-14.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-account_invoice_overdue_reminder/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-14.0/credit-control-14.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-account_invoice_overdue_reminder/
Currently translated at 98.9% (185 of 187 strings) Translation: credit-control-14.0/credit-control-14.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-account_invoice_overdue_reminder/fr/
…mail vals generation
b49ef71 to
de5e2d9
Compare
|
Hi, @alexis-via please check this PR and approve |
|
This PR has the |
|
Hi @stferraro. Your command failed:
Ocabot commands
More information
|
AnizR
left a comment
There was a problem hiding this comment.
Thanks for your work !
I have some nit picking regarding the 'translation' of fields (I see that it has already been flagged).
| ("mail", self.env._("E-mail")), | ||
| ("phone", self.env._("Phone")), | ||
| ("post", self.env._("Letter")), |
| ("onebyone", self.env._("One by One")), | ||
| ("mass", self.env._("Mass")), |
| ("last_reminder", self.env._("Last Reminder")), | ||
| ("last_invoice", self.env._("Last Invoice")), | ||
| ("invoice_contact", self.env._("Invoice Contact")), |
|
Thanks for the review and the positive feedback, @AnizR! Highly appreciate it. 🙏 |
petrus-v
left a comment
There was a problem hiding this comment.
Just repeating other review and suggest imrprovement in test, otherwise looks good to me !
non locking issue
| ("onebyone", self.env._("One by One")), | ||
| ("mass", self.env._("Mass")), |
There was a problem hiding this comment.
Already mentioned by (@rrebollo and @AnizR )
This tuple do not needs to be translated as this will be transparently done by ORM as part of the field selection behavior
| ("onebyone", self.env._("One by One")), | |
| ("mass", self.env._("Mass")), | |
| ("onebyone", "One by One"), | |
| ("mass", "Mass"), |
There are others in this PR
| self.assertEqual(rec.display_name, expected) | ||
|
|
||
| def test_reject_in_invoice(self): | ||
| with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
Odoo cas raose VamodatonError for different reason, alaways a good Idea to assert the message to make sure the proper exception is raising using self.assertRaisesRegex
de5e2d9 to
3810bcf
Compare
|
@petrus-v please make code review , and approve ! |
| <menuitem | ||
| id="overdue_reminder_result_menu" | ||
| action="overdue_reminder_result_action" | ||
| sequence="100" |
There was a problem hiding this comment.
account.menu_finance lands it in Invoicing app root:
Just use parent="account.account_reports_management_menu" like the other ones in this module.
PS: on Enterprise this menu now resurrects an otherwise-empty "Invoicing" app containing just "Overdue Reminder Results". And yes, some EE implementations use this module :)
3810bcf to
651564b
Compare
No description provided.