[16.0][FIX] account_credit_control: translate credit line table in emails - #571
Open
astirpe wants to merge 1 commit into
Open
[16.0][FIX] account_credit_control: translate credit line table in emails#571astirpe wants to merge 1 commit into
astirpe wants to merge 1 commit into
Conversation
astirpe
marked this pull request as ready for review
July 24, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior:
When generating credit control emails with the
mail_show_invoice_detailoption enabled, the injected HTML table containing the invoice details ("Invoices summary", "Due date", etc.) is rendered in the language of the user triggering the action (or the cron user). It ignores the partner's configured language.Expected behavior:
The injected table's headers, date formats, and currency formats should seamlessly match the language of the recipient, aligning with how the rest of the
mail.templateis translated.Proposed changes:
_get_credit_control_communication_tableincredit.control.communicationto force the environment context to matchcontact_address_id.lang(falling back toen_US) before evaluating the_("...")gettext aliases and format helpers.langfield of the credit control mail templates.test_credit_control_communication_translation.pyto ensure the context propagation successfully translates the standard table headers.