[19.0][FIX] sale_financial_risk: set require_signature=False in payment test - #572
Merged
OCA-git-bot merged 1 commit intoAug 19, 2026
Conversation
Odoo 19.0 (odoo/odoo#280403) re-added a `_has_to_be_signed()` check to sale.payment.transaction._check_amount_and_confirm_order, so an online payment no longer auto-confirms a quotation that still requires an online signature. On databases where the company enables Online Signature, the test order gets require_signature=True and stays in 'draft', breaking test_payment_risk_bypass. Disable signature on the test order, matching the fix odoo applied to its own sale/pos tests.
OCA-git-bot
added
series:19.0
mod:sale_financial_risk
carlos-lopez-tecnativa
approved these changes
Aug 19, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just clarify that the PR that introduces this change is odoo/odoo#280403.
@pedrobaeza, please review this.
pedrobaeza
changed the title
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 153ffd6. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] sale_financial_risk: set require_signature=False in payment test
Odoo 19.0 (odoo/odoo#278854) made sale.payment.transaction
_check_amount_and_confirm_order check
_has_to_be_signed(), so an onlinepayment no longer auto-confirms a quotation that still requires an online
signature. On databases where the company enables Online Signature, the
test order gets require_signature=True and stays in 'draft', breaking
test_payment_risk_bypass with 'draft' != 'sale'.
Disable signature on the test order, matching the fix odoo applied to its own sale/pos tests, so the test isolates the risk-bypass behaviour it
actually checks.