[IMP] website_sale_product_assortment #975
Open
+108
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CarlosRoca13, |
Pablocce
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
5 times, most recently
from
ef4cf6f
to
f58223c
Compare
Pablocce
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
from
3fb2022
to
a249a20
Compare
danielduqma
approved these changes
Nov 3, 2024
pedrobaeza
reviewed
Nov 4, 2024
| no_restriction_assortments = any( | ||
| assortment.website_availability == "no_show" for assortment in assortments | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please remove extra empty lines inside a method.
There was a problem hiding this comment.
Done! Thanks for the correction
CarlosRoca13
reviewed
Nov 7, 2024
| assortment_restriction = False | ||
| allowed_product_ids = set() | ||
|
|
|
|
||
| if not no_restriction_assortments: | ||
| return allowed_product_ids, assortment_restriction | ||
|
|
| "|", | ||
| ("website_ids", "=", website.id), | ||
| ("website_ids", "=", False), | ||
| ] | ||
| ) | ||
| ) | ||
| assortment_dict = {} | ||
| partner_assortments = self.env["ir.filters"].sudo() | ||
|
|
| if assortment.website_availability != "no_restriction": | ||
| partner_assortments |= assortment | ||
| allowed_product_ids.update(assortment.all_product_ids.ids) | ||
|
|
|
And if you can, add a test to check that is working OK on future migrations 😄 |
Pablocce
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
2 times, most recently
from
2abb8e5
to
60bc3f6
Compare
|
Ups! the whitespaces still there... |
Pablocce
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
from
60bc3f6
to
a60663d
Compare
… products * Methods that calculate product availability based on e-commerce assortments are being corrected to make them compatible.
Pablocce
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
from
a60663d
to
efbb7a1
Compare
Done! I was doing the rebase, thanks! |
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When more than one assortment is applied to the customer on e-commerce, the functionality doesn't work correctly, and the configurations are not applied properly, for example, when combining "no restriction" with "no show" or "no purchase."
This PR is essential for the functionality of this module because the products are not shown or cannot be bought when they should.
Cases covered with this improvement:
Solution:
To resolve this problem, we have made the following modifications: