[18.0][FIX] edi_storage_oca: ls whitespace filename with ftp protocol #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method fs.ls() fails to correctly parse FTP filenames with spaces. This change bypasses fs.ls for the FTP protocol and uses the underlying fs.ftp.nlst() method directly, which returns the correct full filenames.
Assume a directory /data exists on the FTP server containing a file named "my file.txt".
Actual output when using fs.ls with ftp protocol:
['/data/file.txt']Expected Output:
['/data/my file.txt']Since this seems to be a bug in the fsspec library, I used fs.ftp.nlst() as a workaround. I've also reported the issue on their GitHub: fsspec/filesystem_spec#1970