[18.0][IMP] edi_queue_oca: implement on fail hooks - #331
Conversation
|
TODO: include #335 |
9489b75 to
a00b195
Compare
|
@simahawk backport of #335 is now included; also, the test-req.txt file updates have been reverted now that OCA/queue#971 has been merged. |
|
to include #336 |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-331-by-simahawk-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
I've blocked the merge, the version must be changed as this is a new feature. |
Rely on new on fail hooks from the queue job module.
The on fail hooks introduced in b3290c7 are declared in a noupdate data file, so databases created before that commit never got `on_fail_method` on the exchange record job functions, and failed jobs do not update the exchange record state. Add a post-migration script to fill the missing values.
The hook joins `exc_name` and `exc_message` as strings, but the message stored by queue_job is the first argument of the exception, which is the errno for an OSError and may also be missing. The join then raises a TypeError and the exchange record is not updated.
ce45ade to
83ff2d7
Compare
I kept the upgrade in case someone was already using it. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a26ccb4. Thanks a lot for contributing to OCA. ❤️ |
6 participants
Backport of #324
Depends on