[17.0][MIG] fleet_vehicle_category: Migration to 17.0 #173

BhaveshHeliconia · 2024-12-31T12:53:39Z

No description provided.

Currently translated at 100.0% (12 of 12 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/pt_BR/

Currently translated at 58.3% (7 of 12 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/tr/

Currently translated at 100.0% (15 of 15 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/it/

Currently translated at 100.0% (15 of 15 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/pt_BR/

Currently translated at 100.0% (16 of 16 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_category/it/

Currently translated at 100.0% (16 of 16 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_category/pt_BR/

BhaveshHeliconia · 2025-04-08T12:15:58Z

Hey @OCA/fleet-maintainers would be great if someone could have a look at this module.

WesleyOliveira98

LGTM

OCA-git-bot · 2025-04-08T14:43:49Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rpsjr · 2025-04-08T14:48:08Z

fleet_vehicle_category/i18n/fleet_vehicle_category.pot

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 16.0\n"


review version needed

rpsjr · 2025-04-08T14:48:50Z

fleet_vehicle_category/i18n/it.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 14.0\n"


review version needed

rpsjr · 2025-04-08T14:49:13Z

fleet_vehicle_category/i18n/pt_BR.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 14.0\n"


review version needed

rpsjr · 2025-04-08T14:49:30Z

fleet_vehicle_category/i18n/tr.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 14.0\n"


review version needed

rpsjr · 2025-04-08T14:51:42Z

fleet_vehicle_category/readme/HISTORY.md

+
+- \[MIG\] Module Migration
+
+## 16.0.1.0.0 (2024-09-12)


version 17 history missing

rpsjr

Albeit there are in-code's code documentation related to the code version that needs review (comments made on the code),

LGTM

BhaveshHeliconia · 2025-04-09T05:31:02Z

@rpsjr , Thanks for suggestions! Please Review.

rpsjr · 2025-04-09T12:33:28Z

@rpsjr , Thanks for suggestions! Please Review.

all good!

ivantodorovich · 2025-04-09T13:40:00Z

fleet_vehicle_category/tests/test_vehicle_category.py

+
+
+class TestFleetVehicleCategory(TransactionCase):
+    def setUp(self):


Hey, these added unit tests don't really add much value.
There's no business logic in this module, just fields. We don't need to test the ORM

BhaveshHeliconia · 2025-04-10T05:01:54Z

@ivantodorovich, I removed test folder Please Review when you get chance.

ivantodorovich

Thanks!

/ocabot merge nobump

OCA-git-bot · 2025-04-10T11:58:52Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-173-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-10T12:02:19Z

Congratulations, your PR was merged at d8f0cad. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia changed the title ~~[18.0][MIG] fleet_vehicle_category: Migration to 18.0~~ [17.0][MIG] fleet_vehicle_category: Migration to 17.0 Dec 31, 2024

BhaveshHeliconia mentioned this pull request Jan 1, 2025

Migration to version 17.0 #125

Open

9 tasks

mymage and others added 19 commits February 28, 2025 15:11

[12][ADD] new module fleet_vehicle_category

10b7ff0

[MIG] fleet_vehicle_category: Migration to 13.0

9002458

[IMP] fleet_vehicle_category: black, isort, prettier

f27b27f

[MIG] fleet_vehicle_category: Migration to 14.0

f3867fe

Added translation using Weblate (Portuguese (Brazil))

315e01c

Translated using Weblate (Portuguese (Brazil))

564e444

Currently translated at 100.0% (12 of 12 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/pt_BR/

Added translation using Weblate (Turkish)

577cb44

Translated using Weblate (Turkish)

71598b4

Currently translated at 58.3% (7 of 12 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/tr/

[FIX] security access

e6aaed3

[IMP] add category menuitem, form_view and category description

2292056

Added translation using Weblate (Italian)

48041fa

Translated using Weblate (Italian)

5d3d414

Currently translated at 100.0% (15 of 15 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/it/

Translated using Weblate (Portuguese (Brazil))

f8e5c89

Currently translated at 100.0% (15 of 15 strings) Translation: fleet-14.0/fleet-14.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_category/pt_BR/

[MIG] fleet_vehicle_category: Migration to 15.0

b363f06

[IMP] fleet_vehicle_category: pre-commit stuff

8231b65

[MIG] fleet_vehicle_category: Migration to 16.0

9cbafb6

Translated using Weblate (Italian)

99b7bf7

Currently translated at 100.0% (16 of 16 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_category/it/

Translated using Weblate (Portuguese (Brazil))

69cc53c

Currently translated at 100.0% (16 of 16 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_category Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_category/pt_BR/

[IMP] fleet_vehicle_category: pre-commit auto fixes

63699b1

BhaveshHeliconia force-pushed the 17.0-mig-fleet_vehicle_category branch from 28bf3f1 to 4634d89 Compare February 28, 2025 09:42

marcelsavegnago approved these changes Mar 5, 2025

View reviewed changes

marcelsavegnago requested review from ivantodorovich, rpsjr, kaynnan and WesleyOliveira98 April 8, 2025 13:41

WesleyOliveira98 approved these changes Apr 8, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 8, 2025

OCA-git-bot added the ready to merge label Apr 8, 2025

rpsjr reviewed Apr 8, 2025

View reviewed changes

fleet_vehicle_category/i18n/it.po Outdated

#

msgid ""

msgstr ""

"Project-Id-Version: Odoo Server 14.0\n"

Copy link

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review version needed

rpsjr reviewed Apr 8, 2025

View reviewed changes

fleet_vehicle_category/i18n/pt_BR.po Outdated

#

msgid ""

msgstr ""

"Project-Id-Version: Odoo Server 14.0\n"

Copy link

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review version needed

rpsjr reviewed Apr 8, 2025

View reviewed changes

fleet_vehicle_category/i18n/tr.po Outdated

#

msgid ""

msgstr ""

"Project-Id-Version: Odoo Server 14.0\n"

Copy link

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review version needed

rpsjr reviewed Apr 8, 2025

View reviewed changes

fleet_vehicle_category/readme/HISTORY.md

- \[MIG\] Module Migration

## 16.0.1.0.0 (2024-09-12)

Copy link

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 17 history missing

rpsjr approved these changes Apr 8, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 17.0-mig-fleet_vehicle_category branch from 4634d89 to 4ecdcb6 Compare April 9, 2025 05:30

ivantodorovich reviewed Apr 9, 2025

View reviewed changes

[MIG] fleet_vehicle_category: Migration to 17.0

dacb7c0

BhaveshHeliconia force-pushed the 17.0-mig-fleet_vehicle_category branch from 4ecdcb6 to dacb7c0 Compare April 10, 2025 04:19

ivantodorovich approved these changes Apr 10, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 10, 2025

OCA-git-bot merged commit 4cd19d3 into OCA:17.0 Apr 10, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] fleet_vehicle_category: Migration to 17.0 #173

[17.0][MIG] fleet_vehicle_category: Migration to 17.0 #173

BhaveshHeliconia commented Dec 31, 2024

BhaveshHeliconia commented Apr 8, 2025

WesleyOliveira98 left a comment

OCA-git-bot commented Apr 8, 2025

rpsjr Apr 8, 2025

rpsjr Apr 8, 2025

rpsjr Apr 8, 2025

rpsjr Apr 8, 2025

rpsjr Apr 8, 2025

rpsjr left a comment •

edited

Loading

BhaveshHeliconia commented Apr 9, 2025

rpsjr commented Apr 9, 2025

ivantodorovich Apr 9, 2025

BhaveshHeliconia commented Apr 10, 2025

ivantodorovich left a comment

OCA-git-bot commented Apr 10, 2025

OCA-git-bot commented Apr 10, 2025



		class TestFleetVehicleCategory(TransactionCase):
		def setUp(self):

[17.0][MIG] fleet_vehicle_category: Migration to 17.0 #173

[17.0][MIG] fleet_vehicle_category: Migration to 17.0 #173

Conversation

BhaveshHeliconia commented Dec 31, 2024

BhaveshHeliconia commented Apr 8, 2025

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 8, 2025

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

rpsjr Apr 8, 2025

Choose a reason for hiding this comment

rpsjr left a comment • edited Loading

Choose a reason for hiding this comment

BhaveshHeliconia commented Apr 9, 2025

rpsjr commented Apr 9, 2025

ivantodorovich Apr 9, 2025

Choose a reason for hiding this comment

BhaveshHeliconia commented Apr 10, 2025

ivantodorovich left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 10, 2025

OCA-git-bot commented Apr 10, 2025

rpsjr left a comment •

edited

Loading