[16.0][IMP] l10n_nl_xaf_auditfile_export: reduce memory footprint#445
Open
[16.0][IMP] l10n_nl_xaf_auditfile_export: reduce memory footprint#445
Conversation
Member
Author
|
pre-commit fixed in #446 |
hbrunn
force-pushed
the
16.0-l10n_nl_xaf_auditfile_export-memory
branch
from
dc83c17 to
01aa472
Compare
NL66278
approved these changes
Apr 13, 2026
Contributor
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
👍 LGTM. Great improvement!
hbrunn
force-pushed
the
16.0-l10n_nl_xaf_auditfile_export-memory
branch
from
01aa472 to
a3c07ca
Compare
OCA-git-bot
added
mod:l10n_nl_xaf_auditfile_export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this keeps memory usage for generating the auditfile constant by not having the xml fully loaded in memory. when having xmllint installed, the xml file is never fully loaded at all.
the zipped version then is the upper bound for memory usage, but thankfully xml compresses pretty well.
while being on it I made the auditfile_success flag readonly because users have no business changing that.
should migrate quite straightforwardly to higher versions