[FIX] Remove last non installable addon when it is marked as installable#670
Open
david-banon-tecnativa wants to merge 1 commit intoOCA:masterfrom
Open
Conversation
david-banon-tecnativa
force-pushed
the
imp-update-pre-commit-excluded-addons-remove-last
branch
from
8a0ba51 to
8e01398
Compare
david-banon-tecnativa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When changing a module from
installable:Falsetoinstallable:True, if no modules withinstallable:Falseremain in the repo, pre-commit ignore doesn't run, keeping that last module in the pre-commit ignore filesFix
This PR runs the pre-commit update when there are no addons with
installable:Falseto remove the last ones from pre-comit exclude@Tecnativa