[17.0][MIG] purchase_sale_inter_company by cuongnmtm · Pull Request #604 · OCA/multi-company

cuongnmtm · 2024-03-26T14:05:25Z

Depends on:

[17.0][MIG] account_invoice_inter_company #595

cuongnmtm · 2024-03-27T07:11:15Z

[FIXED] TODO: Fix this

github-actions · 2024-07-28T12:17:32Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pomazanbohdan · 2024-08-01T07:11:16Z

/ocabot migration purchase_sale_inter_company

OCA-git-bot · 2024-08-01T07:11:27Z

Sorry @pomazanbohdan you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pomazanbohdan · 2024-08-01T07:16:58Z

/ocabot migration purchase_sale_inter_company

@cuongnmtm
Would you be so kind as to repeat the note to the bot?

cuongnmtm · 2024-08-01T07:42:42Z

@pedrobaeza please help to trigger /ocabot migration purchase_sale_inter_company, thank you.

OCA-git-bot · 2024-08-01T07:42:52Z

Sorry @cuongnmtm you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

cuongnmtm · 2024-08-01T07:43:24Z

@pedrobaeza please help to trigger /ocabot migration purchase_sale_inter_company, thank you.

OCA-git-bot · 2024-08-01T07:43:34Z

Sorry @cuongnmtm you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

cuongnmtm · 2024-08-01T07:43:41Z

TODO: Fix this

Probably I didn't work on this, I will check it soon.

pedrobaeza · 2024-08-01T07:45:43Z

pre-commit fails and https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

cuongnmtm · 2024-08-02T11:31:50Z

@pedrobaeza I fixed the pre-commit issues and added a reference to another pull request. For the code coverage, I tried adding two automated tests to improve it, but it somehow required writing tests for the tests...

pedrobaeza · 2024-08-02T17:06:55Z

OK, I think it can be enough for now.

/ocabot migration purchase_sale_inter_company

JordiMForgeFlow · 2024-11-21T11:21:43Z

@cuongnmtm could you add #721 in the migration?

cuongnmtm · 2024-11-21T11:57:42Z

JordiMForgeFlow

I cherry-picked your commit.

purchase_sale_inter_company 14.0.1.0.1

This is the splitted module from original to remove dependency on stock

Pricelist currency should be same with PO/SO document If corresponding pricelist currency is not the same find or create propriate pricelist

Company contacts can be Vendors to create SO from PO

If purchase_exception or sale_exception modules are installed we have an issue in tests, because order's confirm methods won't be called. Possible fix is to set ignore_exception=True on orders in tests. Exception check could be skipped by setting check_exception=False, as mentioned in base_exception, but in fact it doesn't work.

Pricelist is set with the company

Update v14 latest changes related to test case failing [UPD] Update purchase_sale_inter_company.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-15.0/multi-company-15.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-purchase_sale_inter_company/

[UPD] README.rst

Currently translated at 75.0% (15 of 20 strings) Translation: multi-company-15.0/multi-company-15.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-purchase_sale_inter_company/it/

TT45184

Currently translated at 100.0% (20 of 20 strings) Translation: multi-company-16.0/multi-company-16.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-purchase_sale_inter_company/es/

…pdates When the purchase user updates the PO after the SO is generated and always if both are confirmed and unlocked, we sync the new lines to update the demand. TT46773

Currently translated at 100.0% (25 of 25 strings) Translation: multi-company-16.0/multi-company-16.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-purchase_sale_inter_company/es/

…duct to purchase order line for better extensibility

Currently translated at 100.0% (25 of 25 strings) Translation: multi-company-16.0/multi-company-16.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-purchase_sale_inter_company/it/

cuongnmtm · 2025-05-12T12:22:49Z

I have squashed more administrative commits. Thanks @carlos-lopez-tecnativa for your suggestion.

carlos-lopez-tecnativa · 2025-05-12T12:24:55Z

@pedrobaeza could you please review this

pedrobaeza · 2025-05-12T14:55:40Z

/ocabot merge nobump

OCA-git-bot · 2025-05-12T14:55:47Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-604-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-12T15:01:16Z

Congratulations, your PR was merged at a5aca7c. Thanks a lot for contributing to OCA. ❤️

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch from fd9e02d to 24f2291 Compare March 26, 2024 14:26

This was referenced Mar 27, 2024

Migration to version 17.0 #529

Open

[17.0][MIG] purchase_sale_stock_inter_company #605

Closed

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch from 24f2291 to 02d2ae6 Compare March 27, 2024 13:50

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024

pomazanbohdan mentioned this pull request Aug 1, 2024

[17.0][MIG] account_invoice_inter_company #595

Merged

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch 2 times, most recently from cdcd1f9 to 32cadba Compare August 2, 2024 11:20

OCA-git-bot added this to the 17.0 milestone Aug 2, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch 2 times, most recently from 0c123db to 0094dda Compare September 6, 2024 12:08

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch 2 times, most recently from 0def0bc to a52f752 Compare December 6, 2024 18:30

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch from a52f752 to 9e2d392 Compare December 20, 2024 09:39

Kev-Roche and others added 20 commits May 12, 2025 19:20

[FIX] purchase_sale_inter_company: fix new sale date_order

5d88dcc

purchase_sale_inter_company 14.0.1.0.1

[MIG] Migration to version 15.0

fe5edb8

[MIG] purchase_sale_inter_company: Migration to 15.0

8a24760

[ADD] purchase_sale_inter_company:

e3753ba

This is the splitted module from original to remove dependency on stock

[15.0][IMP] purchase_sale_inter_company:

ff26b5d

Pricelist currency should be same with PO/SO document If corresponding pricelist currency is not the same find or create propriate pricelist

[15.0][IMP] purchase_sale_inter_company:

cf562e9

Company contacts can be Vendors to create SO from PO

[15.0][IMP] purchase_sale_inter_company:

639fb92

Pricelist is set with the company

[FIX] purchase_sale_inter_company: typo in readme

39edbc0

[UPD] README.rst

[MIG] purchase_sale_inter_company: Migration to 16.0

b237d57

TT45184

[FIX] purchase_sale_inter_company: sync confirmed unlocked purchase u…

61ffdfc

…pdates When the purchase user updates the PO after the SO is generated and always if both are confirmed and unlocked, we sync the new lines to update the demand. TT46773

[IMP] purchase_sale_inter_company: add method _check_intercompany_pro…

812fd0b

…duct to purchase order line for better extensibility

[IMP] purchase_sale_inter_company: return created SO

7e9f004

[IMP] purchase_sale_inter_company: pre-commit auto fixes

c960e95

[MIG] purchase_sale_inter_company: Migration to 17.0

5d28385

cuongnmtm force-pushed the 17.0-mig-purchase_sale_inter_company branch from 841bb03 to 5d28385 Compare May 12, 2025 12:21

OCA-git-bot added the bot is merging ⏳ label May 12, 2025

OCA-git-bot merged commit 8fc06a6 into OCA:17.0 May 12, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 12, 2025

Uh oh!

Conversation

cuongnmtm commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cuongnmtm commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2024

Uh oh!

pomazanbohdan commented Aug 1, 2024

Uh oh!

OCA-git-bot commented Aug 1, 2024

Uh oh!

pomazanbohdan commented Aug 1, 2024

Uh oh!

cuongnmtm commented Aug 1, 2024

Uh oh!

OCA-git-bot commented Aug 1, 2024

Uh oh!

cuongnmtm commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Aug 1, 2024

Uh oh!

cuongnmtm commented Aug 1, 2024

Uh oh!

pedrobaeza commented Aug 1, 2024

Uh oh!

cuongnmtm commented Aug 2, 2024

Uh oh!

pedrobaeza commented Aug 2, 2024

Uh oh!

JordiMForgeFlow commented Nov 21, 2024

Uh oh!

cuongnmtm commented Nov 21, 2024

Uh oh!

cuongnmtm commented May 12, 2025

Uh oh!

carlos-lopez-tecnativa commented May 12, 2025

Uh oh!

pedrobaeza commented May 12, 2025

Uh oh!

OCA-git-bot commented May 12, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

cuongnmtm commented Mar 26, 2024 •

edited

Loading

cuongnmtm commented Mar 27, 2024 •

edited

Loading

cuongnmtm commented Aug 1, 2024 •

edited

Loading