[14.0][IMP] product_supplier_inter-multi_company: multi-company supplierinfo#918
Open
HekkiMelody wants to merge 3 commits intoOCA:14.0from
Open
[14.0][IMP] product_supplier_inter-multi_company: multi-company supplierinfo#918HekkiMelody wants to merge 3 commits intoOCA:14.0from
HekkiMelody wants to merge 3 commits intoOCA:14.0from
Conversation
1601f2a to
de6e25e
Compare
Contributor
Author
|
The two commits updating rebel modules and disabling auto-install are due to an incompatibility between This line https://github.com/OCA/product-attribute/blob/14.0/product_supplierinfo_group/models/product_supplierinfo.py#L29 bypasses the logic behind |
Add `company_ids` to supplierinfo in order to make them visible to some but not all companies. This solves an issue with supplierinfo for products shared only among some companies. When creating intercompany supplierinfo automatically, sync the product's `company_ids` with the `supplierinfo`. Steps to reproduce: - product with companies A and B and not C - generate an intercompany supplierinfo - With only company C, try loading the supplierinfo list view -> The supplierinfo is visible to company C, even though the product is not.
490187e to
526e3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
company_idsto supplierinfo in order to make them visible to some but not all companies. This solves an issue with supplierinfo for products shared only among some companies.When creating intercompany supplierinfo automatically, sync the product's
company_idswith thesupplierinfo.Steps to reproduce:
To Do: