[FIX] ir_ui_view_multi_company: avoid invalid AND domains with website views#934
Open
samirGuesmi wants to merge 1 commit intoOCA:18.0from
Open
[FIX] ir_ui_view_multi_company: avoid invalid AND domains with website views#934samirGuesmi wants to merge 1 commit intoOCA:18.0from
samirGuesmi wants to merge 1 commit intoOCA:18.0from
Conversation
Member
Author
yvaucher
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an incompatibility between this module's override of ir.ui.view._get_inheriting_views_domain() and the website module in Odoo 18.
What happens
The intention in website is to remove the ('active','=',True) constraint so inactive website-specific views can override active generic ones.
And then it crashes 💣
When this module wraps the original domain inside expression.AND(), the resulting domain uses prefix operators (&, |).
The website code then removes the ('active','=',True) leaf without rebuilding the boolean structure, which can leave invalid domains such as:
['&', '|', ('company_ids','=',False), ('company_ids','in',[1])]This domain is syntactically invalid and causes errors during module installation (e.g. when loading website_data.xml).