[18.0][FIX] product_tax_multicompany_default - set taxes on all companies#955
Open
enriquemartin wants to merge 1 commit intoOCA:18.0from
Open
[18.0][FIX] product_tax_multicompany_default - set taxes on all companies#955enriquemartin wants to merge 1 commit intoOCA:18.0from
enriquemartin wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @Shide, |
Contributor
|
Egun on Enrique, You could rebase on 18.0 to get rid of red checks... |
enriquemartin
force-pushed
the
18.0-fix-product_tax_multicompany_default
branch
from
5f56834 to
13e2ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user who does not have access to all existing companies sets taxes for a product, it only propagates the tax to the companies to which it has access, leaving the value empty for those to which it does not have access (the
_delete_product_taxes()method executes aDELETEand skips security rules).Therefore, it is necessary to use
sudo()when iterating through the companies to which the tax is to be propagated.