Skip to content

[FIX]pos_partner_birthdate: fixed the issue of if we have a lot of customers and we search a customer using the birthdate with the button search more, result not found. #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

parvezqureshi
Copy link

@OCA-git-bot
Copy link
Contributor

Hi @ecino,
some modules you are maintaining are being modified, check this out!

@parvezqureshi parvezqureshi force-pushed the 17.0-fix-pos_partner_birthdate branch 3 times, most recently from 3249a1f to d4598fe Compare March 12, 2025 14:04
@cvinh
Copy link
Contributor

cvinh commented Mar 12, 2025

cc @vehi-invitu

@cvinh
Copy link
Contributor

cvinh commented Mar 13, 2025

thanks for the PR, we tested here in french at GMT-10 and with several format input (ddmmyyyy or dd/mm/yyyy), it doesn't seem to work as expected
Can you do it language and format date proof ? At least ddmmyyyy and dd/mm/yyyy for french and mmyyyyyy or mm/dd/yyyy for english
Please be aware of timezone because if we are at another timezone than UTC, the date might move +/-1 day

As example @etobella did it like this

var result = super._partner_search_string(partner);

and it works well with the classical search

@parvezqureshi parvezqureshi force-pushed the 17.0-fix-pos_partner_birthdate branch 2 times, most recently from cb9414f to 3ed02fd Compare March 13, 2025 10:54
…stomers and we search a customer using the birthdate with the button search more, result not found.
@parvezqureshi parvezqureshi force-pushed the 17.0-fix-pos_partner_birthdate branch from 3ed02fd to a74d7c8 Compare March 13, 2025 10:55
Copy link
Contributor

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

Copy link

@vehi-invitu vehi-invitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works as expected.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, suggestion, why don't you ask Odoo to add a hook in order to modify the domain filter? this way, you don't need to have this big change.

I made other PRs asking for hooks and they accepted it without an issue:
odoo/odoo#150914

@cvinh
Copy link
Contributor

cvinh commented Mar 20, 2025

Small, suggestion, why don't you ask Odoo to add a hook in order to modify the domain filter? this way, you don't need to have this big change.

I made other PRs asking for hooks and they accepted it without an issue: odoo/odoo#150914

odoo/odoo#202641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants