Skip to content

[14.0][MIG] pos_tare: Migration to 14.0#980

Closed
baimont wants to merge 28 commits intoOCA:14.0from
acsone:14.0-mig-pos_tare
Closed

[14.0][MIG] pos_tare: Migration to 14.0#980
baimont wants to merge 28 commits intoOCA:14.0from
acsone:14.0-mig-pos_tare

Conversation

@baimont
Copy link
Copy Markdown

@baimont baimont commented Apr 21, 2023

legalsylvain and others added 27 commits April 7, 2023 13:42
@legalsylvain @baimont
[ADD][8.0] pos_tare
da44d2c
@legalsylvain @baimont
[REF] pos_tare: Black python code
354cca3
@legalsylvain @Fkawala @baimont
[MIG] pos_tare: Migration to 12.0
db2d783 
[ADD] barcode nomenclature for tare
[ADD] tare field on pos.order.line model
[ADD] Tare button in PoS numpad
[IMP] handle correctly different UoM
[IMP] add warning at checkout if qty <=0
[IMP] display gross and tare weight for each line

Co-authored-by: François Kawala <francois.kawala@gmail.com>
Co-authored-by: Sylvain LE GAL <sylvain.legal@grap.coop>
@oca-travis @baimont
[UPD] Update pos_tare.pot
34df026
@OCA-git-bot @baimont
[UPD] README.rst
dc4f41e
@OCA-git-bot @baimont
pos_tare 12.0.1.0.1
4690306
@danimv5 @baimont
Added translation using Weblate (Spanish)
09ba906
@danimv5 @baimont
Translated using Weblate (Spanish)
fc3db49 
Currently translated at 100.0% (46 of 46 strings)

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/es/
@oca-travis @baimont
[UPD] Update pos_tare.pot
0ac84d9
@oca-transbot @baimont
Update translation files
6508d9c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
@legalsylvain @baimont
[FIX] pos_tare : raise an error if the gross weight is not correct
c6a8b79
@legalsylvain @baimont
[FIX] pos_tare : move the confirm popup regarding null or negative qu…
1aa252c 
…antity in the correct place
@oca-travis @baimont
[UPD] Update pos_tare.pot
ada6c5e
@OCA-git-bot @baimont
pos_tare 12.0.1.0.2
e36c487
@oca-transbot @baimont
Update translation files
cc340a9 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
@oca-travis @baimont
[UPD] Update pos_tare.pot
61a3434
@oca-transbot @baimont
Update translation files
3ab0fd8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
@legalsylvain @baimont
[IMP][12.O] pos_tare : add default tare weight on product.template model
64d85d0
@oca-travis @baimont
[UPD] Update pos_tare.pot
a7d165a
@OCA-git-bot @baimont
[UPD] README.rst
ad8d038
@OCA-git-bot @baimont
pos_tare 12.0.1.0.3
17558c8
@oca-transbot @baimont
Update translation files
915d77e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
@oca-travis @baimont
[UPD] Update pos_tare.pot
3c52604
@oca-transbot @baimont
Update translation files
68a40e2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
@mymage @baimont
Added translation using Weblate (Italian)
5a0a231
@mymage @baimont
Translated using Weblate (Italian)
c393ff7 
Currently translated at 100.0% (55 of 55 strings)

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/it/
@baimont
[IMP] pos_tare: black, isort, prettier
096f471
@legalsylvain
Copy link
Copy Markdown
Contributor

legalsylvain commented Apr 21, 2023

/ocabot migration pos_tare

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Apr 21, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 21, 2023
Open
16 tasks
@sanrav
Copy link
Copy Markdown

sanrav commented Apr 24, 2023

See my issue created for the V12 => #984

In V14, I have the same issue with the tare barcode reading in the scaling screen but the difference with the V12 is that the product is added to the order :

image

@baimont baimont changed the title [14.0][MIG] pos_tare: Migration to 14.0 [DRAFT][14.0][MIG] pos_tare: Migration to 14.0 May 4, 2023
@baimont baimont force-pushed the 14.0-mig-pos_tare branch from c4ee5b4 to 325ae22 Compare May 4, 2023 10:30
@baimont baimont changed the title [DRAFT][14.0][MIG] pos_tare: Migration to 14.0 [14.0][MIG] pos_tare: Migration to 14.0 May 4, 2023
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 17, 2023

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 17, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 17, 2023
@github-actions github-actions Bot closed this Oct 22, 2023
@legalsylvain legalsylvain reopened this Nov 26, 2023
legalsylvain
legalsylvain requested changes Nov 26, 2023
View reviewed changes
Comment thread pos_tare/static/src/js/Screens/ProductScreen/ProductScreen.js
}
}

async _getAddProductOptions(product) {
Copy link
Copy Markdown
Contributor

@legalsylvain legalsylvain Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewriting all this function is not a good option.
I think you can return weight + tare in the payload of the "ScaleScreen", and then overload _getAddProductOptions just to split the quantity field into the two weight and tare. What do you thing ?

Copy link
Copy Markdown
Author

@baimont baimont Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @legalsylvain and thanks for your comment.
As I remember I really tried not to do that but I didn't have the choice. I cannot tell you why exactly as I currently work on other projects and haven't touch this for months. If you are sure of you, you can maybe propose some changes and I'll gladly take a look (and test).

@github-actions github-actions Bot closed this Jan 7, 2024
@robinkeunen robinkeunen mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

+2 more reviewers

@apineux apineux apineux approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

10 participants

@baimont @legalsylvain @sanrav @OCA-git-bot @apineux @FrancoMaxime @oca-travis @danimv5 @oca-transbot @mymage