[19.0][MIG] queue_job_cron_jobrunner: Migration to 19.0 - #979
Closed
dhongu wants to merge 1 commit into
Closed
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
Contributor
Author
|
Closing in favour of #876, which is byte-identical to this branch (same four files: manifest, the not-installable exclude list in The verification carries over to #876, so I have added it as a review there: installed on a clean 19.0 database, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
queue_job_cron_jobrunnerfrom 18.0 to 19.0.The module needed no code change on 19.0 — the addon was already carried over
by
[MIG] Create 19.0 from 18.0 for Odoo 19.0withinstallable: False, andneither
models/ir_cron.pynormodels/queue_job.pytouches anything the 19.0API renamed. So this is the manifest flip plus the housekeeping that goes with
it: version bump to
19.0.1.0.0, the addon removed from the not-installableexclude list in
.pre-commit-config.yaml, andREADME.rst/static/description/index.htmlregenerated for the 19.0 branch.With the addon no longer excluded,
pre-commitnow actually runs over it andpasses clean (ruff, pylint_odoo, prettier/xml).
Test
Installed and ran the module's own test suite on a fresh 19.0 database:
data/ir_cron.xmlstill writesstate/codeonir.cron, which on 19.0 aredelegated fields on
ir.actions.server; that goes through the ORM fine and thecron trigger tests (
test_queue_job_cron_trigger,test_queue_job_cron_trigger_enqueue_dependencies) cover it.@ivantodorovich as maintainer.