Skip to content

[19.0][MIG] queue_job_cron_jobrunner: Migration to 19.0 - #979

Closed
dhongu wants to merge 1 commit into
OCA:19.0from
dhongu:19.0-mig-queue_job_cron_jobrunner
Closed

[19.0][MIG] queue_job_cron_jobrunner: Migration to 19.0#979
dhongu wants to merge 1 commit into
OCA:19.0from
dhongu:19.0-mig-queue_job_cron_jobrunner

Conversation

@dhongu

@dhongu dhongu commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Migration of queue_job_cron_jobrunner from 18.0 to 19.0.

The module needed no code change on 19.0 — the addon was already carried over
by [MIG] Create 19.0 from 18.0 for Odoo 19.0 with installable: False, and
neither models/ir_cron.py nor models/queue_job.py touches anything the 19.0
API renamed. So this is the manifest flip plus the housekeeping that goes with
it: version bump to 19.0.1.0.0, the addon removed from the not-installable
exclude list in .pre-commit-config.yaml, and README.rst /
static/description/index.html regenerated for the 19.0 branch.

With the addon no longer excluded, pre-commit now actually runs over it and
passes clean (ruff, pylint_odoo, prettier/xml).

Test

Installed and ran the module's own test suite on a fresh 19.0 database:

odoo.tests.stats: queue_job_cron_jobrunner: 7 tests 0.29s 237 queries
odoo.tests.result: 0 failed, 0 error(s) of 5 tests

data/ir_cron.xml still writes state/code on ir.cron, which on 19.0 are
delegated fields on ir.actions.server; that goes through the ORM fine and the
cron trigger tests (test_queue_job_cron_trigger,
test_queue_job_cron_trigger_enqueue_dependencies) cover it.

@ivantodorovich as maintainer.

@oca-cla-bot

oca-cla-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@OCA-git-bot OCA-git-bot added series:19.0 mod:queue_job_cron_jobrunner Module queue_job_cron_jobrunner labels Sep 9, 2026
@dhongu

dhongu commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favour of #876, which is byte-identical to this branch (same four files: manifest, the not-installable exclude list in .pre-commit-config.yaml, and the regenerated README/index). I opened this before checking the open PRs — apologies for the noise.

The verification carries over to #876, so I have added it as a review there: installed on a clean 19.0 database, queue_job_cron_jobrunner: 7 tests, 0 failed, 0 error(s).

@dhongu dhongu closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:queue_job_cron_jobrunner Module queue_job_cron_jobrunner series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants