Skip to content

[17.0][MIG] sale_report_delivered_volume: Migration to 17.0#310

Open
BhaveshHeliconia wants to merge 8 commits intoOCA:17.0from
HeliconiaIO:17.0-mig-sale_report_delivered_volume
Open

[17.0][MIG] sale_report_delivered_volume: Migration to 17.0#310
BhaveshHeliconia wants to merge 8 commits intoOCA:17.0from
HeliconiaIO:17.0-mig-sale_report_delivered_volume

Conversation

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Feb 24, 2025
13 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-sale_report_delivered_volume branch from 829bee8 to a06886b Compare February 25, 2025 07:34
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 29, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-sale_report_delivered_volume branch from a06886b to c5586df Compare June 30, 2025 12:35
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-sale_report_delivered_volume branch from c5586df to 0855e46 Compare July 25, 2025 10:06
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 23, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-sale_report_delivered_volume branch from 0855e46 to e105bb3 Compare November 25, 2025 05:08
@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

Hey @OCA/crm-sales-marketing-maintainers would be great if someone could have a look at this module.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025
@rousseldenis
Copy link
Copy Markdown
Contributor

/ocabot migration sale_report_delivered_volume

@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of this as already in BaseCommon

super().setUpClass()
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
cls.partner = cls.env.ref("base.res_partner_12")
cls.product = cls.env.ref("product.product_product_9")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to not rely on demo data but to create new ones in tests.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 17.0-mig-sale_report_delivered_volume branch from e105bb3 to bab22e6 Compare December 10, 2025 11:53
@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

@rousseldenis I've completed your suggested changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants