[19.0][MIG] sale_order_line_position: Migration to 19.0#348
Open
NICO-SOLUTIONS wants to merge 30 commits intoOCA:19.0from
Open
[19.0][MIG] sale_order_line_position: Migration to 19.0#348NICO-SOLUTIONS wants to merge 30 commits intoOCA:19.0from
NICO-SOLUTIONS wants to merge 30 commits intoOCA:19.0from
Conversation
This module adds an auto computed position on sale order line. This position number is added on the report. The position can be used to keep track of each line during the delivery, invoicing of the order with the customer. This is why there is related modules on `account-invoice-reporting` and `stock-logisics-reporting`. The position set on a line is not changed when the order is not in draft anymore.
The previous implementation with the onchange was broken and hardly feasible (onchange are called on each line and the sequence set on them changes on each call) and not possible to cover with unit tests (reproduce the drag and drop). The other solution could have been to replace the onchange with a recompute of the position on every `write` of a sale.order but that also leads to a complex solution. As the positions are needed to discuss with the customer, the recompute of the position on print, send and confirm is a good enough, simple solution.
Currently translated at 81.8% (9 of 11 strings) Translation: sale-reporting-14.0/sale-reporting-14.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-14-0/sale-reporting-14-0-sale_order_line_position/de/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-reporting-15.0/sale-reporting-15.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-15-0/sale-reporting-15-0-sale_order_line_position/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-15.0/sale-reporting-15.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-15-0/sale-reporting-15-0-sale_order_line_position/
Currently translated at 100.0% (13 of 13 strings) Translation: sale-reporting-17.0/sale-reporting-17.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-17-0/sale-reporting-17-0-sale_order_line_position/it/
[UPD] Update sale_order_line_position.pot [BOT] post-merge updates
The position field is not required, so technically it could exists a
sale order line row with a NULL position value.
In that case the computation of the next position number will fail with
unsupported operand type(s) for +: 'NoneType' and 'int'
This change makes sure to not have a crash in such case.
[BOT] post-merge updates
make tests independent and stable - Remove demo data dependencies - Generate sale.order per test to isolate state changes
11 tasks
ng-ife
approved these changes
Feb 18, 2026
is-ife
approved these changes
Feb 19, 2026
Contributor
|
This PR has the |
Contributor
|
I noticed we are instantiating res.partner and product.product in setUpClass, but putting sale.order inside setUp(). Is there a specific reason we have them separated? |
Member
Author
|
I split it intentionally: res.partner and product.product are created in setUpClass because they’re static test data and not modified. sale.order is created in setUp since each test changes it (e.g. unlinking lines, changing state, etc.), so i wanted a fresh instance per test to keep them isolated and independent, while avoiding unnecessary re-creation of shared data. |
Contributor
|
Makes sense, thanks for the clarification 👍 |
BhaveshHeliconia
approved these changes
Apr 8, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code review LGTM!
Member
Author
|
@rafaelbn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standard migration