[18.0][MIG] base_user_effective_permissions: Migration to 18.0 #354
Conversation
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
2 times, most recently
from
e61b84b to
d35c607
Compare
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
from
d35c607 to
aedf873
Compare
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
from
aedf873 to
ab6a1ae
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Currently translated at 100.0% (26 of 26 strings) Translation: server-backend-16.0/server-backend-16.0-base_user_effective_permissions Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_effective_permissions/it/
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
from
ab6a1ae to
11a0a46
Compare
|
Hey @OCA/tools-maintainers would be great if someone could have a look at this module. |
|
@hbrunn : could you take a look on this migration ? |
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
/ocabot migration base_user_effective_permissions
| f"{operation}_domain": IrRule._compute_domain( | ||
| for operation in operations: | ||
| try: | ||
| model.check_access(operation) |
There was a problem hiding this comment.
this is not the equivalent of v16's model.check_access_rights - use ir.model.access#check instead
| vals[f"{operation}_permission"] = True | ||
| except Exception: | ||
| vals[f"{operation}_permission"] = False | ||
| try: |
There was a problem hiding this comment.
under which conditions is this expected to raise? I'd expect something to be very wrong when this happens, and then we shouldn't squelch the exception
There was a problem hiding this comment.
The _compute_domain() method can raise an AccessError when:
- The user doesn't have access to certain ir.rule records
- Domain evaluation fails due to missing fields or invalid domain syntax
- Security restrictions prevent domain computation for specific models
In these cases, setting an empty domain "[]" is appropriate as it indicates no domain-based restrictions beyond the basic access rights check already performed by ir.model.access#check.
However, you're right that we shouldn't squelch all exceptions. I'll update the code to catch only AccessError
There was a problem hiding this comment.
obvious copy&paste from coding assistant, no interest to continue discussion
There was a problem hiding this comment.
@hbrunn here I accept that I used AI but its only to clean up the wording, since sometimes I struggle to words things well. Sorry if that caused any confusion.
Next onwards I will try to best to answer well.
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
from
11a0a46 to
1f9939e
Compare
|
@hbrunn : I’ve made the changes as per your suggestion. Could you please review? Thanks!” |
BhaveshHeliconia
force-pushed
the
18.0-mig-base_user_effective_permissions
branch
from
1f9939e to
2e88e57
Compare
github-actions
bot
removed
the
stale
5 participants
No description provided.